search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.73k stars 377 forks source link

Castle construction screen, vertical and horizontal position of the castle name #1757

Open LeHerosInconnu opened 4 years ago

LeHerosInconnu commented 4 years ago

In fheroes2, the name of the castle is displayed at the top right of this window.

In fheroes2, the name of the castle is not centered horizontally between the edge of the buildings frame and the edge of the screen frame. [Done] I also suggest changing the current vertical position of the castle name 1 pixel down.

In fheroes2:

Building sign position fh2 01

The captain's frame can also be moved to be aligned horizontally with the portrait frames and have the same spacing with the buildings frame. I also modified the width and height dimensions of the captain's frame which is too large for the captain's graphic.

Necro Castle 4 pixels captain moved 01

The size and position of the background of the captain's information will also need to be changed when the captain's quarters are built (this is the window without change).

Necro castle with captain info fh2 01

Branikolog commented 4 years ago

I also suggest changing the current vertical position of the castle name 1 pixel down.

Why? We don't have much space to shift castle down (#1756), to make the name and the castle sprite more distant to each other...

LeHerosInconnu commented 4 years ago

@Branikolog.

I also suggest changing the current vertical position of the castle name 1 pixel down.

Why? We don't hve much space to shift castle down (#1756), to make the name and the castle sprite more distant to each other...

It's okay. By shifting the castle name down 1 pixel, the top of the castle name text line will be 4 pixels from the gray frame of the screen. The baseline of the castle name text line will be 4 pixels from the top of the necromancer castle graphic. The bottom of the castle graphic will be 4 pixels from the top of the yellow frame of the Captain's graphic.

Branikolog commented 4 years ago

I'm afraid it would be too close to Captain's building... I hope, our dev team would show us two this implementations, so we could choose the better-looking one.

LeHerosInconnu commented 4 years ago

@Branikolog.

I'm afraid it would be too close to Captain's building... I hope, our dev team would show us two this implementations, so we could choose the better-looking one.

With the changes made.

Necro Castle 4 pixels 01

The captain's frame can also be moved to be aligned horizontally with the portrait frames and have the same spacing with the buildings frame.

Necro Castle 4 pixels captain moved 01

Branikolog commented 4 years ago

Well, shifting Captain's icon is a good idea... After that, window looks more balanced. Can you also add this item to the first post of this thread?

LeHerosInconnu commented 4 years ago

@Branikolog.

Well, shifting Captain's icon is a good idea... After that, window looks more balanced. Can you also add this item to the first post of this thread?

I modified the first post.

Branikolog commented 4 years ago

Thanks for your help, @LeHerosInconnu! With your contribution our project will shine for years, at the time we'd finish it. :)

LeHerosInconnu commented 4 years ago

@Branikolog.

Thanks for your help, @LeHerosInconnu! With your contribution our project will shine for years, at the time we'd finish it. :)

With the release date fast approaching, the team must hurry up. :)

ihhub commented 2 years ago

The horizontal position of the name must be fixed by now.

LeHerosInconnu commented 2 years ago

@ihhub.

The horizontal position of the name must be fixed by now.

Yes, it's fixed. I have updated the first post.