ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.58k stars 359 forks source link

Kingdom Overview screen, Heroes Overview and Towns/Castles Overview screens, wrong position of elements #1842

Open LeHerosInconnu opened 3 years ago

LeHerosInconnu commented 3 years ago

Kingdom Overview screen, Heroes Overview and Towns/Castles Overview screens, wrong horizontal position of column titles

In fheroes2, the column titles do not have the same horizontal position in their frame as in the original game.

In original game:

Kingdom Heroes H2 01

In fheroes2:

Kingdom Heroes fh2 01

In original game:

Kingdom Towns H2 01

In fheroes2:

Kingdom Towns fh2 01

Open the two images in different tabs in your browser, enlarge the images and switch between the two tabs alternately. Heroes 2 first, fheroes2 second.

Title column H2 01 Title column fh2 01

Title column H2 02 Title column fh2 02

Kingdom Overview screen, Towns/Castles Overview screen, wrong horizontal and vertical position of town names

In fheroes2, town names are not centered horizontally in their frame. In fheroes2, town names do not have the same vertical position in their frame as in the original game.

In original game:

Kingdom Towns H2 01

In fheroes2:

Kingdom Towns fh2 01

Open the two images in different tabs in your browser, enlarge the images and switch between the two tabs alternately. Heroes 2 first, fheroes2 second.

Castle name H2 01 Castle name fh2 01

Kingdom Overview screen, Heroes Overview and Towns/Castles Overview screens, scroll bar incorrectly positioned horizontally

In the original game, the right part of the buttons and scroll bar is cut off or displayed incorrectly. In fheroes2, this problem seems to be fixed, but the scroll bar is incorrectly positioned horizontally.

In original game:

Defect scroll bar H2 01

Defect scroll bar H2 03

Open the two images in different tabs in your browser, enlarge the images and switch between the two tabs alternately. Heroes 2 first, fheroes2 second.

Scroll bar position H2 coupé 01 Scroll bar position fh2 coupé 01

Kingdom Overview screen, Heroes Overview and Towns/Castles Overview screens, center horizontally all numbers of mines and all resource numbers

Center all numbers of mines and other resource generators horizontally in relation to the sprites of mines and other resource generators. Center all resource numbers horizontally relative to resource sprites. I also suggest lowering the vertical position of the numbers of mines and other resource generators by 1 pixel.

In fheroes2:

Kingdom Heroes fh2 01

Kingdom Heroes resources fh2 coupé 01

Kingdom Overview screen, Heroes Overview and Towns/Castles Overview screens, wrong vertical position of the "HEROES", "TOWNS/CASTLES" and "EXIT" buttons

In fheroes2, the vertical position of the "HEROES", "TOWNS/CASTLES" and "EXIT" buttons is not the same as in the original game.

In original game:

Kingdom Heroes H2 01

In fheroes2:

Kingdom Heroes fh2 01

Open the two images in different tabs in your browser, enlarge the images and switch between the two tabs alternately. Heroes 2 first, fheroes2 second.

Kingdom Heroes H2 boutons 01 Kingdom Heroes fh2 boutons 01

Edit 2020/10/02.

I also suggest a small modification for a better visual appearance for the "HEROES", "TOWN/CASTLES" and "EXIT" buttons in order to leave a space of 1 pixel to the top and the right of the buttons. (https://github.com/ihhub/fheroes2/issues/1843)

Branikolog commented 3 years ago

I can add here wrong bottom scrollbar position: image

ihhub commented 3 years ago

Scrollbar is a different issue, not related to any dialog.