ihhub
commented
4 years ago For a person who wants to start fixing this issue please rise a message here as we might need some adjustments in proposed solution.
Open LeHerosInconnu opened 4 years ago
ihhub
commented
4 years ago For a person who wants to start fixing this issue please rise a message here as we might need some adjustments in proposed solution.
Stisen1
commented
1 year ago As of v.1.0.7: When you build a building via Kingdom Overview screen, the resources spend only appear as spend on the adventure map window, if you quit kingdom overview and slide through the windows until the ressource window reappear. I guess a solution to this is either impossible or at least hard to "fix"! But still! I wanted to point this out, as I can see a lot is getting a QoL-change with the kingdom summary screen
zenseii
commented
1 year ago
As of v.1.0.7: When you build a building via Kingdom Overview screen, the resources spend only appear as spend on the adventure map window, if you quit kingdom overview and slide through the windows until the ressource window reappear. I guess a solution to this is either impossible or at least hard to "fix"! But still! I wanted to point this out, as I can see a lot is getting a QoL-change with the kingdom summary screen
I'm not sure I entirely understand what you mean. Is it that the adventure map area resources don't get updated when you build things via the kingdom overview screen? This is the same when done via the castle screen.
Meanwhile, I can see that the kingdom overview screen's gold hasn't been updated and this seems like a bug, unless this is how it works originally.
Stisen1
commented
7 months ago https://github.com/ihhub/fheroes2/assets/118435605/58c8d7f7-9ebf-4c7a-a242-0955a0ae529c
I've recorded this video to demonstrate what it takes to trigger the bug I was talking about.
Regarding the visual aspect.
In fheroes2, frames have been added around the hero's primary skills. The color of these frames is not the same as the yellow color of the frames used in this screen. These frames overlap roughly with the wide top border of the hero frame. The blue background of primary skills has not been removed between the added frames. Why not just go back to the look of the original game and avoid the problems added by these frames?
In fheroes2, the number of creatures is positioned over the sprite of creatures. In the original game, the number is positioned below the sprite, it's better that way, and there's plenty of room to do it.
In the original game, the position of the sprite of the creatures makes that the lower part of the yellow frame of the hero's primary skills is covered by the sprite of the large creatures, in the example, the sprite of the Black Dragons, the Titans and the Bone Dragons. In fherores2, it would be necessary to position the sprite of the creatures so that this does not happen.
In fheroes2, frames have been added around the creatures. The color of these frames is not the same as the yellow color of the frames used in this screen. These frames have a plain brown background, why not keep the original background, which is more pleasing to the eye? Adding this frame poses a problem with the Dragon sprite which is displayed over the frame on the right and the Dragon sprite shadow which is displayed over the frame on the left. The last frame on the right overlaps roughly with the wide right border of the hero frame. Then again, why not just go back to the look of the original game (with the change in the position of the sprite of the creatures) and avoid the problems added by these frames?
In fheroes2, the way to display hero secondary skills has been changed. The color of these frames is not the same as the yellow color of the frames used in this screen. The frames are "welded" together. Empty frames are displayed. The background of empty frames is not the same as the frames occupied by a secondary skill. Adding these empty frames gives a feeling of oppression when viewing this screen. There is already enough stuff to look at without having to add unused frames in addition, and leaving some blank space in this screen is much better. Again, I am for a return to the presentation of the screen as in the original game.
In fheroes2, the way to display hero artifacts has been changed. The color of these frames is not the same as the yellow color of the frames used in this screen. Empty frames are displayed. The background of the empty frames is not the same as in the original game (Heroes Meeting screen). Same remarks as for the way to display the hero's secondary skills: Adding these empty frames gives a feeling of oppression when viewing this screen. There is already enough stuff to look at without having to add unused frames in addition, and leaving some blank space in this screen is much better. Again, I am for a return to the presentation of the screen as in the original game.
In fheroes2, frames have been added around the garrison creatures. The color of these frames is not the same as the yellow color of the frames used in this screen. These frames have a plain brown background. Adding this frame poses a problem with the Dragon sprite which is displayed over the frame on the right and the Dragon sprite shadow which is displayed over the frame on the left. The first and last frame overlap the wide border on either side of the frames. The number of creatures is positioned over the creature sprite. The creatures appear to be "stuck" in the frame. The simple presentation of the original game is fine, there is no need to add these frames.
In fheroes2, frames have been added around the available creatures. The color of these frames is not the same as the yellow color of the frames used in this screen. These frames have a plain brown background. Adding this frame poses a problem with the Dragon sprite which is displayed over the frame on the right and left, and the Dragon sprite shadow which is displayed over the frame on the left. The number of creatures is positioned over the creature sprite. The creatures appear to be "stuck" in the frame. The simple presentation of the original game is fine, there is no need to add these frames. Additional information has been added, it can very well be added without there being a frame, which would even allow this information to be displayed with more spacing with the sprite of the creatures. The actions possible by clicking on the sprites of the creatures can be just as possible without the frames, as is already the case in the original game.
In summary for the visual aspect, it would be necessary to remove the frames which bring more problems than anything else and return to the presentation of the original game with the few modifications indicated.
In original game:
In fheroes2:
In original game:
In fheroes2:
Regarding practicality.
Now in fheroes2, some of these frames are used to perform specific actions, like changing the position of creatures in the hero's army and in the garrison of towns, or even changing the position of artifacts in the hero's inventory.
This is my proposal to solve the visual aspect problems and keep the practicality.
Parts of frames only are used for creatures, positioned at the bottom near the number of creatures, and frames are used for artifacts. Frames, and parts of frames (for creatures), are not visible until the user needs them. They are therefore "displayed" in transparent color, so the user does not see them in the interface. The position of sprites and numbers of creatures should be adjusted vertically and horizontally, as in the examples. For creature growth information and building information (in the example "+8" and white "x") they are simply displayed centered above the unframed creature sprite.
When the user wants to change the position of creatures in the hero's army or in the town garrison, or to change the position of artifacts in the hero's inventory, the frames and parts of frames are displayed to serve as "guide" with the glowing color as currently. The position of sprites and numbers of creatures should be adjusted vertically and horizontally, as in the examples.
I also suggest reducing the horizontal spacing of the creature sprites in the "Available" column and centering the creature block horizontally in the frame to prevent the Dragon sprite from being too close to the edge of the frame on the right.