search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.74k stars 377 forks source link

Musics and sounds, transition between musics and complet sounds #1981

Open LeHerosInconnu opened 4 years ago

LeHerosInconnu commented 4 years ago

All over the game, whenever there is a transition between different musics, or when a music must be interrupted (for example at the end of a combat), there should be a fade in the sound (the sound level is attenuated until it is no longer heard) before switching to the other music and when the music needs to be stopped.

Also when a sound is played, it must be fully played before the next action is taken.

In fheroes2, for example during combat, when the last opposing creature is decimated, the creature's sound may not be fully played and may be cut off abruptly when the end of combat window is displayed. The end of combat window should only be displayed when all combat sounds have been fully played. The music of the combat is also cut off abruptly when the end of combat window is displayed.

Related issue: https://github.com/ihhub/fheroes2/issues/1979.

Branikolog commented 4 years ago

Also, I can add here, that sounds from the terrain objects, such as Xanadu, Hill Fort, Troll Bridge should be played till the end. Now they are interrupted after player press OK button.