search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.65k stars 371 forks source link

Castle screen, fully built castle, differences noticed #2059

Open LeHerosInconnu opened 3 years ago

LeHerosInconnu commented 3 years ago

In fheroes2, there are defects due to the display priority of sprites or/and sprites which are displayed differently. In fheroes2, some defects have already been corrected compared to the original version of the game, they have not been reported here.

Sorceress' Castle.

In original game:

Castle screen H2 003

In fheroes2:

Castle screen fh2 003

Open the two images in different tabs in your browser, enlarge the images and switch between the two tabs alternately. Heroes 2 first, fheroes2 second.

Castle screen H2 captain coupé 003 Castle screen fh2 captain coupé 003

Edit 2020/12/21.

Knight's Castle.

To comply with the creature buildings color code, red for unimproved buildings and blue for upgraded buildings. Knight castle, inverted the sprites for the Archery Range and the Upg. Archery Range (red and blue).

TWNKDW_1.ICN 0000.bmp

TWNKUP_1.ICN 0000.bmp

CSTLKNGT.ICN 0020.bmp

0025.bmp

Necromancer's Castle.

There is a problem with the Laboratory road connection.

In fheroes2: Laboratory road flaw fh2 01

In original game, corrected: Laboratory road corrected H2 01

There is a problem with the Mage Guild road connection.

In fheroes2: Mage Guild road flaw fh2 01

In original game: Mage Guild H2 01

Necromancer castle screen, changes needed to avoid display "flaws" when switching between castles with Mausoleum and upgraded Mausoleum. The position of the sprites must be adjusted. Note: Graphic modifications have also been applied, they will be specified in another issue (changes to the half top of the sprite).

TWNNDW_4.ICN 0000.bmp

TWNNUP_4.ICN 0000.bmp

In fheroes2: Dwelling Lich position fh2 01

In fheroes2: Dwelling Lich position fh2 02

In original game, corrected: Dwelling Lich position corrected H2 02

Open the three images in different tabs in your browser, enlarge the images and switch between the three tabs alternately. fheroes2 unimproved dwelling first, fheroes2 upgraded dwelling second, Heroes 2 corrected position third.

Dwelling Lich position fh2 coupé 01 Dwelling Lich position fh2 coupé 02 Dwelling Lich position corrected H2 coupé 02

All changes applied (graphics change included). Heroes 2 original first, Heroes 2 corrected second. Original-0000 Change-0000

ihhub commented 3 years ago

Hi @LeHerosInconnu , I've updated the order of building drawing. I didn't close this issue. Please check it again (once the compilation is done) and let me know if something is missing or simply close the issue if everything is fine. What I fixed:

Of course not everything could be fixed as I noticed that the original game has even more issues than our.

LeHerosInconnu commented 3 years ago

@ihhub.

Hi @LeHerosInconnu , I've updated the order of building drawing. I didn't close this issue. Please check it again (once the compilation is done) and let me know if something is missing or simply close the issue if everything is fine. What I fixed:

  • Tavern drawing in Barbarian castle
  • Captain drawing in Necromancer castle
  • Statue drawing in Knight castle
  • Library drawing in Wizard castle

Of course not everything could be fixed as I noticed that the original game has even more issues than our.

All the changes you have made are working properly. For other problems, it will certainly be necessary to slightly modify the graphics because a change in display priority will not necessarily solve the problem.

I suggest leaving the issue open as a reminder for the other problems. If it's ok, I'll edit the first post to leave only the problems unfixed.

ihhub commented 3 years ago

Yes, please edit the first message. Maybe these pixel related issues because of another incorrect ICN decoding.

LeHerosInconnu commented 3 years ago

@ihhub.

Yes, please edit the first message. Maybe these pixel related issues because of another incorrect ICN decoding.

I edited the first post.

ihhub commented 3 years ago

@ihhub.

Yes, please edit the first message. Maybe these pixel related issues because of another incorrect ICN decoding.

I edited the first post.

Mmm.. I don't see any changes :(

LeHerosInconnu commented 3 years ago

@ihhub.

@ihhub.

Yes, please edit the first message. Maybe these pixel related issues because of another incorrect ICN decoding.

I edited the first post.

Mmm.. I don't see any changes :(

Maybe I hadn't updated the change. :) It should be fine now.

ihhub commented 3 years ago

@LeHerosInconnu well, it happens. No worries :)

ihhub commented 3 years ago

Hi @LeHerosInconnu could you please verify castle drawings with latest commit? I made fixes for Barbarian castle roads.

Regarding different pixels in Knight and Sorceress castles: it might be that we miss some extra logic about image transcoding. I made some changes for images but it looks like it's not the case. So I don't know what's wrong with them.

LeHerosInconnu commented 3 years ago

Hello @ihhub,

Hi @LeHerosInconnu could you please verify castle drawings with latest commit? I made fixes for Barbarian castle roads.

Regarding different pixels in Knight and Sorceress castles: it might be that we miss some extra logic about image transcoding. I made some changes for images but it looks like it's not the case. So I don't know what's wrong with them.

Your corrections for the routes of the barbarian castle are working correctly. It's perfect. :) Did you modify the sprites "in the program", by cutting part of the sprites for example?

In these castles screens, there are also other flaws that have not been corrected in fheroes2, do you want me to report them in this thread, or it can wait?

I've modified the first post accordingly.

ihhub commented 3 years ago

Hi @LeHerosInconnu , I didn't modify any sprites but made a correct order of drawings.

If you spot some issues with sprites like incorrect pixels or colors, for example Calavry sprite which we fixed yesterday, please create a thread for this. We might able to fix it within an application without using modified assets of the game.

LeHerosInconnu commented 3 years ago

@ihhub.

Hi @LeHerosInconnu , I didn't modify any sprites but made a correct order of drawings.

If you spot some issues with sprites like incorrect pixels or colors, for example Calavry sprite which we fixed yesterday, please create a thread for this. We might able to fix it within an application without using modified assets of the game.

Okay, I will add the other defects of the castles in this thread and create another thread for the other defects.

LeHerosInconnu commented 3 years ago

First post updated with other flaws for Knight's Castle and Necromancer's Castle.

ihhub commented 3 years ago

Hi @LeHerosInconnu , could you please update the first post in regards to Knight castle since we fixed the issue with the Farm?

LeHerosInconnu commented 3 years ago

Hello @ihhub,

Hi @LeHerosInconnu , could you please update the first post in regards to Knight castle since we fixed the issue with the Farm?

First post updated.

Eldorias-Piano-Covers commented 2 years ago

Here is an animated gif concerning the Mosoleum pixel offset I was about to post (v 0.9.14) : A

ihhub commented 1 year ago

Reclassifying this issue as asset enhancement with target for beyond 1.0.