ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.73k stars 377 forks source link

Hero screen, Spell Scroll, notify the player when the spell contained in the Spell Scroll is only temporarily inscribed in the Hero's Magic Book #2121

Open LeHerosInconnu opened 4 years ago

LeHerosInconnu commented 4 years ago

In fheroes2, it would be nice to notify the player when the spell contained in the Spell Scroll is only temporarily inscribed in the Hero's Magic Book.

These screens are for explanatory purposes only. In fheroes2:

In the hero's screen, the Spell Scroll graphic is different. Tempo spell scroll modifié 01

In the Hero Meeting screen, the Spell Scroll graphic is different. Tempo spell scroll modifié 02

In the hero's Magic Book, this is also indicated. Tempo spell scroll modifié 03

In the spell information window, a sentence is also added to indicate this: "The Haste spell is temporarily inscribed in your Magic Book as you have a Spell Scroll that contains this spell." Tempo spell scroll 04

In the Spell Scroll information window, a sentence is also added to indicate this, depending on the case: "The Haste spell is temporarily inscribed in your Magic Book." Tempo spell scroll modifié 05

"The Haste spell is already permanently inscribed in your Magic Book." Tempo spell scroll 05

Related issue: https://github.com/ihhub/fheroes2/issues/2120.

Edit.

In the Shrine's information window, this is also indicated: "(Haste) (spell scroll)"

(or eventually: "(Haste) (known with spell scroll)") Tempo spell scroll 06

ihhub commented 4 years ago

Hi @LeHerosInconnu , could you please hold your suggestion topics for a while as newcomers might take these without any discussions? I'm sure you have a lot of them but please just keep them for a while as we would like to sort and fix some of these 500+ issues so it will be cleaner to see the path on what we are :)

LeHerosInconnu commented 4 years ago

Hello @ihhub,

Hi @LeHerosInconnu , could you please hold your suggestion topics for a while as newcomers might take these without any discussions? I'm sure you have a lot of them but please just keep them for a while as we would like to sort and fix some of these 500+ issues so it will be cleaner to see the path on what we are :)

Okay, fine. :)