Adventure map, expand the information on terrain penalties to all squares of the adventure map

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.

https://ihhub.github.io/fheroes2/

GNU General Public License v2.0

2.68k stars 373 forks source link

Adventure map, expand the information on terrain penalties to all squares of the adventure map #2198

Open LeHerosInconnu opened 3 years ago

LeHerosInconnu commented 3 years ago

In fheroes2, information about penalties of the terrain adjacent to the hero has been added.

This feature should be extended to all the squares of the adventure map and not only to the squares adjacent to the heroes. And the Pathfinding skill of the hero should be taken into account to indicate the terrain penalty according to the selected hero. When there is no hero selected, the standard terrain penalty is displayed. [Edit 2021/11/16: Not yet done.] This feature can also be an option.

In fheroes2:

Terrain penalty fh2 01

Branikolog commented 3 years ago

I think we must add this as option to config menu. Not all people like watching this "penalty numbers" in game. Also, we can try to activate this option with simultaneous right click with pressing any button on keyboard (Like shift or Alt)

vincent-grosbois commented 3 years ago

I see to be honest I'm in favor of completely removing this. Reason is:

it's yet one more config flag to add more settings
I don't really see the added value Basically you can already know by how much you can travel by clicking or hovering the mouse. This just give info about the penalty point based on the tile type and pathfinding. I don't think many people even know/count these. I mean, not every "engine details" needs to be made visible in the UI

But otherwise it's super simple to implement/fix

Branikolog commented 3 years ago

I suspect this option is not working correctly, but I even haven't created an issue, because I believe, we implement more useful penalty indicator in future...

LeHerosInconnu commented 3 years ago

@vincent-grosbois and @Branikolog.

In the current version, it does not have much interest. In a version extended to all squares of the adventure map, this can be useful to check the terrain penalty depending on the hero selected without having to open the hero screen.

Very useful on large maps with several heroes to plan movements according to the hero's effective penalty on the types of terrain he will have to cross.

But yes, it is more of a "quality of life" option than anything else. :)

LeHerosInconnu commented 2 years ago

Everything is done, except: "When there is no hero selected, the standard terrain penalty is displayed.".

In fheroes2:

Terrain penalty no hero selected 001

Terrain penalty no hero selected 002

Terrain penalty no hero selected 003

Terrain penalty no hero selected 004