ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.66k stars 371 forks source link

Not up-to-date focus in high resolution when changing focus in some windows #2598

Open vincent-grosbois opened 3 years ago

vincent-grosbois commented 3 years ago

You can see this when you do the following:

Something similar in castle window:

Something similar in hero window:

I think there must be other bugs, where basically the righ-side bar is never updated when actions are performed in a sub-window. Note that this can be fixed, like I've done for kingdom view: https://github.com/ihhub/fheroes2/pull/2597 Basically by redrawing the world map, then redrawing the window

Branikolog commented 3 years ago

Hi, @vincent-grosbois. Cannot say, it's a bug... As original game doesn't support higher resolutions, the ability to watch GUI and World map surrounding windows mentioned above is the case appeared in fheroes2. So in fheroes2 it was implemented, that all the GUI of the game is not updated, while you perform any actions in the window. Anyway, the idea is good and I hope game engine allows us to implement it. Also, I want to add to your suggestion, we should implement interaction with GUI, so, if you click on castle icon in a bar to the right, we can switch castles in current window without pressing arrow buttons or closing it.

Branikolog commented 3 years ago

Between, changing focus on exit the window, while switching castles or heroes with arrow buttons, while hero/castle window is open should be a separate issue, as we can easily fix it, i hope.