Combat, the sound of the Elf shot seems to be played three times, it is audible after the sound of the target troop being hit is played

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.

https://ihhub.github.io/fheroes2/

GNU General Public License v2.0

2.7k stars 375 forks source link

Combat, the sound of the Elf shot seems to be played three times, it is audible after the sound of the target troop being hit is played #4329

Open LeHerosInconnu opened 3 years ago

LeHerosInconnu commented 3 years ago

Preliminary checks

[X] I've checked that there aren't other open issues on the same topic.
[X] I've checked that this issue is reproducible on the latest snapshot build.

Platform

Windows

Describe the bug

In fheroes2, the sound of the Elf shot seems to be played three times, it is audible after the sound of the target troop being hit is played.

I did not test with other ranged creatures.

In fheroes2:

Elf shot sound 01

Activate the sound of the video.

https://user-images.githubusercontent.com/43583994/136198716-7bbb539f-0fc7-47a2-a463-74721c5b0386.mp4

Save file

Here is the save file: Before elf sound test 01.zip

Additional info

Version 0.9.8 4311

Branikolog commented 3 years ago

Hi, @LeHerosInconnu. I think there's no issue here. Your combat speed is so high and elves' target is so close to them, so the sound of two shots finish after the sound of taken damage by a creature. If you set the speed a bit slower, this effect reduces.

LeHerosInconnu commented 3 years ago

Hello @Branikolog,

Hi, @LeHerosInconnu. I think there's no issue here. Your combat speed is so high and elves' target is so close to them, so the sound of two shots finish after the sound of taken damage by a creature. If you set the speed a bit slower, this effect reduces.

Wouldn't it be possible to reduce the duration of the sound while keeping the same tonality? I don't know if it would be possible to do this "on the fly" depending on the selected animation speed.

Branikolog commented 3 years ago

For each combat speed we need to make a certain sound duration. Also, while playing on an excessively high speeds sounds will be played too short, which can sound not well. Actually, the OG has the same issue, but it's not so obvious there, as the OG doesn't offer so high speeds. :)