Adventure map, creature recruitment window should be centered horizontally and vertically on the adventure map

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.

https://ihhub.github.io/fheroes2/

GNU General Public License v2.0

2.73k stars 377 forks source link

Adventure map, creature recruitment window should be centered horizontally and vertically on the adventure map #4596

Closed LeHerosInconnu closed 3 years ago

LeHerosInconnu commented 3 years ago

Preliminary checks

[X] I've checked that there aren't other open issues on the same topic.
[X] I've checked that this issue is reproducible on the latest snapshot build.

Platform

Windows

Describe the bug

In fheroes2, the creature recruitment window should be centered horizontally and vertically on the adventure map. However, it should not be centered in a city (to allow the player to see (a bit) :) the garrisoned creatures). At least as long as the creature recruitment window is not modified to see garrisoned troops and the hero's army troops more comfortably.

In fheroes2:

Recruit creatures 001

Recruit creatures 002

Save file

Here is the save file: Before recruit ghosts 01.zip

Additional info

No response

Branikolog commented 2 years ago

Hello, @ihhub! What about well?

LeHerosInconnu commented 2 years ago

Hello everyone,

Hello, @ihhub! What about well?

Oh, I forgot about this screen. :D Yes, the window should also be centered here. :)

LeHerosInconnu commented 2 years ago

@ihhub and @Branikolog.

And also in this screen. :) Is it necessary to open another issue?

In fheroes2:

Center recruit 10

ihhub commented 2 years ago

Hi @LeHerosInconnu , if we don't have such issue please make it.

LeHerosInconnu commented 2 years ago

Hello @ihhub,

Hi @LeHerosInconnu , if we don't have such issue please make it.

This is no longer necessary, thanks. :)

LeHerosInconnu commented 2 years ago

Hello @ihhub,

The creature recruitment window has been centered in the "Well" and "Towns/Castles Kingdom Overview" screens.

In fheroes2:

From an aesthetic point of view, I suggest moving the recruitment window down 2 pixels in the "Well" screen to avoid seeing that part of the creature's Dwelling graphic indicated by the red arrow. Recruit windon position well flèche 01

And, still from an aesthetic point of view, for the "Towns/Castles Kingdom Overview" screen, I suggest to center vertically the recruitment window in the upper part of the screen, indicated by the red frame, in order to avoid cutting and also hiding the resource generators graphics. Recruit window position town overview cadre 02

Edit.

I will open an issue for this. (https://github.com/ihhub/fheroes2/issues/4749)