Closed LeHerosInconnu closed 2 years ago
I tried to fix most of the things in https://github.com/ihhub/fheroes2/pull/4851, except for the following:
"Experimental Parameters" are two separate strings, so in order to get a French translation with correct word order, one would have to translate "Experimental" as "Paramètres" and "Parameters" as "Experimentaux". That would screw up these translations when they are used separately. We will need to add context to these strings to make them unique.
"Savoir" is nice, but "Connaissance" is used in a lot of places, including artefact names. I'd rather not rename these, googling for "ultime livre du savoir" and finding nothing is not cool.
"Quelques" sounds good, but I would like a second opinion on this one before making the changes, as "Plusieurs" is used in the GoG version.
Regarding (#4827):
Hello @dimag0g,
Regarding (#4827):
- "Le Château ... augmente les revenus de 1000 pièces" is wrong. The castle doesn't increase your income by 1000, but only by 500 (from 500 to 1000).
This proposal was made to remain consistent with the text of the Statue.
In fheroes2: (The word "d'or" is also missing here.) :)
Also your comment would be valid if all castles were first towns that were later improved into castles. But this is not the case and often castles are directly castles without being towns first. (For information, a town gives 250 gold, not 500 gold.) :)
Also, the use of "à" may imply that it is the entirety of the Kingdom's income that is being referred to, when in fact it is not and refers only to this castle (whereas with the use of "de" this imprecision disappears).
Therefore, it should be clarified in the sentence: "...augmente les revenus du château...".
As it is the case for the Statue: "...augmente les revenus de votre village de 250 pièces...".
In fheroes2:
Another solution would be to replace the word "augmente" by "génère" in the texts of Town, Castle and Statue:
"...génère des revenus de..."
I'll stick to "...génère des revenus de..." then, this is IMO the most inambiguous sentence which can be applied to all 3 cases (Statue, Donjon, Castle)
Hi @LeHerosInconnu , is this issue still relevant?
Hello @ihhub,
Everything seems to be correct apart from "Connaissance" and "Plusieurs".
In fheroes2:
Version 0.9.13 5123
Seeing that they're small corrections they can be included in the PR that I have going.
Actually, now that the current French PR got larger than I had intended, I would add these changes to the next French PR that is planned to be posted, to avoid further growth of this current PR.
Also I would like to ask what the solution to these would be. Abbreviations like "Plus." and "Connaiss." ?
Hello @zenseii,
Actually, now that the current French PR got larger than I had intended, I would add these changes to the next French PR that is planned to be posted, to avoid further growth of this current PR.
Also I would like to ask what the solution to these would be. Abbreviations like "Plus." and "Connaiss." ?
The abbreviations are not visually appealing and not easily understood by someone who does not know the game.
I had proposed that:
The word "Plusieurs" is too long. The word "Plusieurs" could be replaced by "Quelques" a slightly shorter word.
The word "Connaissance" is too long. The word "Connaissance" could be replaced by "Savoir".
"Connaissance" could also be kept by adjusting the horizontal position of the values. :)
@LeHerosInconnu , then I believe the best solution is to adjust the horizontal position of the primary skill values since I don't see how it could be a problem if they are placed further to the right. This is much better than sometimes using Savoir and other times Connaissance, which would indeed be confusing to new players trying to learn the terminology used in the game.
As for Quelques I see no problems with that other than that it might still pixel by pixel be the same length as Plusieurs due to wider letters. Still this will only be discovered by trying it.
Hello @zenseii and @ihhub,
@LeHerosInconnu , then I believe the best solution is to adjust the horizontal position of the primary skill values since I don't see how it could be a problem if they are placed further to the right. This is much better than sometimes using Savoir and other times Connaissance, which would indeed be confusing to new players trying to learn the terminology used in the game.
@ihhub, so do you think it is appropriate to adjust the horizontal position of all values in this window?
In fheroes2:
As for Quelques I see no problems with that other than that it might still pixel by pixel be the same length as Plusieurs due to wider letters. Still this will only be discovered by trying it.
Let's try it. :)
@LeHerosInconnu Here's Quelques: It's better but not yet perfect/acceptable.
I suspect you wouldn't be much in favor of the (common) abbreviation Qlqs.
😅.
I would agree if you if you said it's a bit ugly to look at in the game, especially since abbreviations aren't commonly used.
How about in those quick info dialogs writing "Plus" as in more and then in more detailed window Plusieurs?
Divers or Certains would be within the limit, only problem is you need the feminine variants Diverses and Certaines, so you'd end up having to use the too long Divers/es
and having to use slash is also terrible. The Italian one is full slashes. A system for differentiation between feminine and masculine would be great, but I digress.
@zenseii.
@LeHerosInconnu Here's Quelques: It's better but not yet perfect/acceptable.
I suspect you wouldn't be much in favor of the (common) abbreviation
Qlqs.
sweat_smile I would agree if you if you said it's a bit ugly to look at in the game, especially since abbreviations aren't commonly used.
Effectively, it is better, but still too long. I still think that replacing the terms by the corresponding numbers would only bring advantages: https://github.com/ihhub/fheroes2/issues/1530. :) Otherwise, I have no other ideas for the moment.
Just noticed the a
in affiche
is missing for some weird reason:
Looking at the .mo in hex it seems some weird encoding snuck in:
I also recommend in the next PR for French to adopt the "Quelques" as suggested above.
EDIT: The 'a' was fixed. Quelques is a bad idea because it is used for "A few..." too and would be very confusing. It's either plusieurs or nothing at this point unless the window gets larger.
I'll have a French PR up and running shortly.
@LeHerosInconnu I've seen that the original French localization uses the 1 à 4 for Few etc. and I see that you would have prefered this way as well. Other than making a more true to the English translation, is there a reason we should insist on not applying such a system for creature quantities in the French translation?
Hello @zenseii,
I'll have a French PR up and running shortly.
@LeHerosInconnu I've seen that the original French localization uses the 1 à 4 for Few etc. and I see that you would have prefered this way as well. Other than making a more true to the English translation, is there a reason we should insist on not applying such a system for creature quantities in the French translation?
There is none to my eyes. :) For me it would be more convenient and clearer to display the numbers directly wherever the expressions are used, even for the English language. And besides there would be no problem with translations with long words in some languages, etc.
But some guy wants to keep the expressions... ...but he can still change his mind... :)
"So replace:
Few by 1-4 Several by 5-9 Pack by 10-19 Lots by 20-49 Horde by 50-99 Throng by 100-249 Swarm by 250-499 Zounds by 500-999 Legion by 1000+"
For reference here is the original French localization:
That picture with the titans shows why using this system wouldn't be the best (that bottom line makes me feel dyscalculic). Also the system of adjective/verbal descriptions is used too:
I'm not really in favor of enforcing the 1-4 etc. system to all languages, but I think it's important to repect what system players will have gotten used to in their specific localization of the game.
@zenseii.
For reference here is the original French localization:
That picture to the right shows why using this system wouldn't be the best (that bottom line makes me feel dyscalculic). Also the system of adjective descriptions is used too:
I found that the use of "à" with a space on each side was not very clear in the original French version either (as you illustrated with Ambrose's army). That's why I changed "500 à 1000" to "500-999" with a hexadecimal editor.
And even for the quick info of the wandering creatures, it is quite clear and precise:
I'm not really in favor of enforcing the 1-4 etc. system to all languages, ...
Booouuuuuu... :rofl:
I found that the use of "à" with a space on each side was not very clear in the original French version either (as you illustrated with Ambrose's army). That's why I changed "500 à 1000" to "500-999" with a hexadecimal editor.
Yes, this will look much better and a French person will still read it as 500 à 1000. The small font dash -
also looks fine compared to the horrible normal font dash.
I'm still not convinced this is the best solution to adapt for wandering creatures, though, simply because it changes much of the atmosphere of the game into something boring and numerical.
Booouuuuuu... 🤣
Well well let's take one victory at a time 😋 Maybe one day we will see this system applied in other langauges.
Here are some other issues:
Here's another issue I spotted in a vid from current latest public release:
I looked a bit further into this and this only happens when you have the French assets and for this specific letter:
The output of this string is this:
Ma>tres Spadassins
This is in other words an issue that would be solved if we used CP1252 formatting for French when assets are present, or just forced use of font generation even when assets are supplied.
Edit: Turns out this was due to that small font letter's asset had a lot of blank space to the right of it. It has veen solved some time ago.
Other issues were reported by Damn3d:
Demi-tour
Alliance des ogres
Hello @zenseii,
Other issues were reported by Damn3d:
Demi-tour
Alliance des ogres
Some remarks.
I think "Fléau des nains" would be better than "Nain fléau". Or "Fléau des Nains", if the first letter should be capitalized as for the word "Dragons".
And I suggest "Renforts différés" instead of "Forces reportées".
Hello @zenseii,
Other issues were reported by Damn3d:
Demi-tour
Alliance des ogres
Some remarks.
I think "Fléau des nains" would be better than "Nain fléau". Or "Fléau des Nains", if the first letter should be capitalized as for the word "Dragons".
And I suggest "Renforts différés" instead of "Forces reportées".
Actually, I'm pretty sure Fléau des nains was used, but I think some update just has it "fuzzied" or marked as needing to be checked.
Thanks for your other suggestions!
Hi @LeHerosInconnu !
And I suggest "Renforts différés" instead of "Forces reportées".
I want to make sure that your suggestion here refers to how these are "Carry-over forces", in other words forces you accumulated in one map that will carry over to a subsequent map later on. "Renforts différés" seems to translate to "Postponed reinforcements" which sounds like they will arrive later than planned?
You'll have to excuse me if the answer is obvious.
When this is cleared up I believe we can close this issue.
Hello @zenseii,
Hi @LeHerosInconnu !
And I suggest "Renforts différés" instead of "Forces reportées".
I want to make sure that your suggestion here refers to how these are "Carry-over forces", in other words forces you accumulated in one map that will carry over to a subsequent map later on. "Renforts différés" seems to translate to "Postponed reinforcements" which sounds like they will arrive later than planned?
You'll have to excuse me if the answer is obvious.
When this is cleared up I believe we can close this issue.
The difference is subtle and both could be used, it's all about the reader's interpretation. :) For me, "reportées" means more that something was planned in advance but there was a problem so it has to be rescheduled, like a rescheduled event. "différés" would be more consistent with something that does not happen right away but is delayed in time, such as a "live" as opposed to a "replayed" television broadcast.
Also, since it is possible to get information about bonuses with the right mouse click, we could also use these expressions:
"Troupes rassemblées"
Or simply:
"Renforts"
With something like this for the bonus information message:
"Les renforts seront disponibles dans le scénario final."
"Les renforts seront disponibles pour le combat final."
"Les troupes seront disponibles dans le scénario final."
"Les troupes seront disponibles pour le combat final."
Thanks for the thorough explanation, @LeHerosInconnu!
I'm not qualified to decide which is better. I'm also not sure what the current info window for this reward says, but it should already be present.
If you don't mind I'll share your suggestions on Discord to the other French native speakers.
Hi @LeHerosInconnu. Here is the current right-click description in English and French. Don't pay too much attention to the fact that the English text has some mistakes.
I believe a more correct text would be "The army will be carried over to a subsequent scenario", because the carried over army arrives to you in the final battle (I think?), which is not the scenario immediately following the one you get that bonus in, if I recall correctly.
Sadly my campaign saves no longer work and I don't have the time to speed through the campaign, nor the will to look it up elsewhere.
Nevertheless, this bonus could be applied for other campaigns in the future so having the text fit more situations would be better, but not very important.
Hello @zenseii,
Hi @LeHerosInconnu. Here is the current right-click description in English and French. Don't pay too much attention to the fact that the English text has some mistakes.
I believe a more correct text would be "The army will be carried over to a subsequent scenario", because the carried over army arrives to you in the final battle (I think?), which is not the scenario immediately following the one you get that bonus in, if I recall correctly.
Sadly my campaign saves no longer work and I don't have the time to speed through the campaign, nor the will to look it up elsewhere.
Nevertheless, this bonus could be applied for other campaigns in the future so having the text fit more situations would be better, but not very important.
Beware, in Archibald's campaign, the gathered troops are available in the next scenario which is the final scenario, while in Roland's campaign, the gathered troops are not available in the next scenario (which is not the final scenario) but in the very last scenario.
The following sentence might be appropriate for both campaigns:
"L'armée sera disponible dans le scénario final."
Hi @LeHerosInconnu,
"L'armée sera disponible dans le scénario final."
Thanks! I've not gotten much response on Discord yet, but in my opinion simply "Renforts" and "Les renforts seront disponibles dans le scénario final." sound the best and make the most sense.
We're deciding between this:
and this:
For reference the troops will be found within Archibald's troops in the beginning of the final evil scenario:
I'm not sure my french is good enough to understand the exact meaning of "conservées" in the above example, so for me "disponibles" sounds better.
Seeing that we have a visual representation of the troops we could also make a direct reference to them like:
"The following troops will be among your ranks in the final scenario:"
~ "Les troupes suivantes seront dans vos rangs dans le scénario final :"
Though that doesn't explain where you got them from, in case you forget how you got that bonus.
Maybe just simply: "Les troupes suivantes rejoindront vos rangs dans le scénario final :"
We can consider this discussion for how to improve the English text as well later on.
Do you have any thoughts @LeHerosInconnu?
Hello @zenseii,
I'm not sure my french is good enough to understand the exact meaning of "conservées" in the above example, so for me "disponibles" sounds better.
Seeing that we have a visual representation of the troops we could also make a direct reference to them like:
"The following troops will be among your ranks in the final scenario:"
~ "Les troupes suivantes seront dans vos rangs dans le scénario final :"
Though that doesn't explain where you got them from, in case you forget how you got that bonus.
Maybe just simply: "Les troupes suivantes rejoindront vos rangs dans le scénario final :"
We can consider this discussion for how to improve the English text as well later on.
Do you have any thoughts @LeHerosInconnu?
For me, "Renforts" and "Les renforts seront disponibles dans le scénario final." fit perfectly. :)
And for the window, what happens when the army includes five different types of creatures? Is the window adapted to that already?
Edit:
This sentence can also be used:
"Les renforts rejoindront vos rangs dans le scénario final."
This sentence can also be used:
"Les renforts rejoindront vos rangs dans le scénario final."
Good. I'll change it to your second proposal. I'm so finished with going back and forth on this single sentence so many times now 😂
And for the window, what happens when the army includes five different types of creatures? Is the window adapted to that already?
The window adapts automatically, yet I'm not sure this is relevant to this discussion?
Btw you suggestion works even if the "reinforcements" should only end up being a single goblin, in case that is the result after the final battle, whereas "Les troupes" would be logically wrong in that case since it's just one single troop 👍
Preliminary checks
Platform
Windows
Describe the bug
So, here are the problems I noticed.
The letter "é" in "Résolution" and "Expérimental". The word "Language" should be "Langage". The word "Experimental" should be "Expérimentaux". All words certainly not translated.
Problem with "Random". Edit 2021/12/23: The word "Random" could be replaced by the word "Hasard".
The word "Connaissance" is too long. The word "Connaissance" could be replaced by "Savoir". And "Pt de magie" could be replaced by "Mana".
The word "Plusieurs" is too long. The word "Plusieurs" could be replaced by "Quelques" a slightly shorter word. (It would be better to use the corresponding numbers "5-9".) :D
Apart from that, there are still texts in English, errors with masculine and feminine forms, articles "le", "la" not accorded with the noun, etc. (https://github.com/ihhub/fheroes2/discussions/4827)
Save file
Not needed.
Additional info
No response