search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.69k stars 375 forks source link

Question / bug on monster growth #4893

Closed vincent-grosbois closed 2 years ago

vincent-grosbois commented 2 years ago

Preliminary checks

Platform

Windows

Describe the bug

cf https://github.com/ihhub/fheroes2/blob/84b4d57dd0aacec2f955cb962bf7506f47979e50/src/fheroes2/maps/maps_tiles_quantity.cpp#L1104

My questions:

Save file

none

Additional info

No response

oleg-derevenetz commented 2 years ago

I believe @LeHerosInconnu is able to answer this question. He knows everything :)

LeHerosInconnu commented 2 years ago

Hello @vincent-grosbois and @oleg-derevenetz,

I believe @LeHerosInconnu is able to answer this question. He knows everything :)

I won't say that I know everything, but there is a link about creature growth in Heroes 2 in this thread: https://github.com/ihhub/fheroes2/discussions/4676. :)

Edit 2022/01/05.

The original page is in Russian. With Google Chrome, it is possible to right click on the page and a menu is displayed allowing to translate the page. With Firefox, it's a bit more complicated because it's as if Google is putting "obstacles in the wheels" of Firefox when you try to translate the page. :)

vincent-grosbois commented 2 years ago

Unfortunately my dedication to the fheroes2 project doesn't go as far as learning Russian... Does anyone know what they say ? apparently it's exactly the formula I mentionned in the first message indeed

vincent-grosbois commented 2 years ago

In that page, they also mention how the garrison monster should grow when there is a neutral town. Do we handle this at all in the game ?

felix642 commented 2 years ago

Unfortunately my dedication to the fheroes2 project doesn't go as far as learning Russian... Does anyone know what they say ? apparently it's exactly the formula I mentionned in the first message indeed

Hi @vincent-grosbois, from what I can see on the website, we seem to be missing a small part of code to make it work like OG

"N new = N + [N / 7] + Bonus , where Bonus = 1 with probability P (Bonus = 1) = {N / 7} , and Bonus = 0 otherwise, "

We do not handle the bonus. Every week we should have 1/7 chances to add 1 monster to the pack.

Adding this logic would probably solve the issue.

vincent-grosbois commented 2 years ago

thanks, I was able to translate it with google trad

Every week we should have 1/7 chances to add 1 monster to the pack.

I don't think that's what they write, it's dependant on the fractionary part of N/7. So for n=1 that's 1/7 chance to add 1, but for n=6 that's 6/7 to add 1, which is by chance what I had proposed in my OP :)

Branikolog commented 2 years ago

@vincent-grosbois True. According to this guide we have a quite low chance of increasing quantity of 1 neutral monster on adventure map. I've done some tests in the OG. Single Dragon, placed on adventure map received growth only up to the 4-th month.

idshibanov commented 2 years ago

In that page, they also mention how the garrison monster should grow when there is a neutral town. Do we handle this at all in the game ?

Yes: #1872. Although I noticed small differences (like 40/101 chance instead of 40%) overall it matches current implementation.

Article seems to be spot-on judging by my own notes from a year ago. The only thing that we're missing is %7 random chance bonus.