ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.73k stars 377 forks source link

Missing context for skill bonuses for campaigns #5214

Closed zenseii closed 2 years ago

zenseii commented 2 years ago

Preliminary checks

Platform

Other

Describe the bug

Currently the skill choices for campaign bonuses do not have their own context and in other langauges than English this leads to these strings being too long for the bonus area: image

The below discussion shows the awards for reference, but every skill should have its award context for future-proofing when more campaigns are added and even in English you could potentially make a campaign with a bonus of Advanced Pathfinding which would be too long: https://github.com/ihhub/fheroes2/discussions/4541

This should be a good first issue since you could most likely follow this PR's approach: https://github.com/ihhub/fheroes2/pull/4971/files#diff-14a58fb744cf2a6f1030e616fb38bd64411b3dab4cbdda3a099e7b7062dd0811

Save file

Here's a save for having completed the first Voyage Home scenario. It has two skill bonuses. Voyage Home 1 Complete.zip

To test others you can edit a po file and change the first scenario's awards to see how they are in game.

Additional info

Not really relevant for fixing this issue but currently awards should be no longer than 16-18 characters (whitespace included) depending on what letters are used.

zenseii commented 2 years ago

I'll have a look at addressing this now.