ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.71k stars 376 forks source link

Make building names lowercased when possible #5246

Open zenseii opened 2 years ago

zenseii commented 2 years ago

Preliminary checks

Describe the problem requiring a solution

Now that lowercasing of strings were implemented in https://github.com/ihhub/fheroes2/pull/4976 more strings can be made lowercase to stay consistent with the implementation in the aformentioned PR.

Completed tasks - [x] Select {Monster} - This is lowercased in the OG ![image](https://user-images.githubusercontent.com/12501091/162641630-e8b328b9-78da-4a52-a48f-1e65c14d7b6e.png) - [x] Recruit {Monster} . There are at least two of them: ![image](https://user-images.githubusercontent.com/12501091/162641659-23e465ab-bf64-4b52-828b-05affe9465ef.png) This second one is not in lowercase in the OG but the one above is. ![image](https://user-images.githubusercontent.com/12501091/162641669-a8804e4e-e15b-4ef3-8037-990c020439be.png) - [x] Many strings in battle log as well could use this. These are lowercased in the OG. ![image](https://user-images.githubusercontent.com/12501091/162642547-047c4454-e0eb-486f-8688-28b19d440bb3.png)

Describe the possible solution

You basically just need to use Translation::StringLower() like done in https://github.com/ihhub/fheroes2/pull/4976/files#diff-a4e630f2f0de5508d00515b54754d4a2e5db85014707a61735b2bc5ef4024769R287

There might need to be made extra contexts for the various strings to avoid a sentence starting with a lowercased string.

If we want to keep some of these strings in uppercase to keep in line with the OG, then maybe the best solution is to make it possible to specify it for different languages. Code that does something related to this for German is already present.

Additional info

No response

LeHerosInconnu commented 2 years ago

@zenseii.

For my part, I prefer to keep the names of creatures, buildings, etc. with the first letter capitalized (at least for the English version). I find it more pleasing to the eye, especially in the "titles". And it also makes it easier to find them in a text. For other languages, it could be adjusted to fit the text conventions.

There had already been discussions or remarks on this subject if I remember correctly (no time to search). :)