String contexts for several strings

zenseii commented 2 years ago

Preliminary checks

[X] I've checked that there aren't other open issues on the same topic.

Describe the problem requiring a solution

More contexts should be added for these strings both for improving the game and to accomodate for other languages:

[ ] Abbreviated and unabbreviated building names to be allowed to write things like Upgraded blacksmith where the space permits it. This would be very helpful for many languages that lack a proper translation for "upgraded":
[ ] Arena primary skills. The German word Verteidigung is randomly broken mid-word
[x] Class in scenario information. This should be seen in relation to https://github.com/ihhub/fheroes2/issues/5244
[ ] Speed in the combat options. Speed in this case is different from the speed attribute of creatures for several languages. (Polish is used to show where I'm talking about. Not sure if this is the case for Polish.)
[ ] Spell names in cases they should be contained within 2 lines and not. A solution of implementing line-breaking at hyphens - wouldn't be optimal because the hyphen should be removed if single-lined.
[ ] Secondary skill level placed on the bottom of the skill icon is definable for each skill in translations of the OG. This is needed for cases when the adjective changes gender like "Logistica Esperta" but "Orientamento Esperto". This avoids unnecessary use of /.

Describe the possible solution

For the most part you would need to add the usual context prefix ex. combatOption|Speed. For Classes you'll need to create another enumeration since right now only the Necromancer class has its own context in a switch - another approach should probably be used to avoid having to switch through every class name.

Additional info

No response

zenseii commented 1 year ago

Related closed PR #5983

zenseii commented 1 year ago

Many of these are still valid, and there are many more throughout the engine. Most of them should be easy fixes so I'm marking it as good first issue.

felix-schneider commented 2 days ago

Digging this up again. Similar to my thoughts on #9260, even though it would lead to many more strings, the descriptions of the buildings may need individual translation strings. In some languages, both the article of the building name and the grammatical form of the creature they produce may be different from the base form.

Edit: regarding 2 and 5: The elegant way of solving this would be the use of a soft hyphen. That is probably not available in many of the encodings that the translations are in. What would it take to make all translation files use Unicode? Of course, the rendering code would need to support it as well.

ihhub commented 2 days ago

Hi @felix-schneider , using Unicode is not possible by 2 reasons:

the original game uses code pages (actually each copy of the game uses its own code page). This lead to a fact that now the whole texts depend on code pages. We don't have Unicode support in the code
we have no default font. Almost every single non-English letter is generated by the engine. Once Unicode is being added we have to solve the problem with fonts

ihhub / fheroes2