ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.74k stars 377 forks source link

Give a choice to make room for Alliance creatures #5249

Open zenseii opened 2 years ago

zenseii commented 2 years ago

Preliminary checks

Describe the problem requiring a solution

If you have a creature alliance bonus like Dwarven Alliance in the Good Campaign and you don't have room for dwarves, they will simply let you pass and disappear. This is how OG works but fheroes2 lets you choose and potentially dismiss creatures for neutral armies that want to join: image

Describe the possible solution

I suggest implementing an option in the dialog for alliance creatures. There would be some need for reworking of the logic and order of these dialogs.

Like this maybe:

  1. They offer to join and you get to choose yes or no and to look at your army 2a. You deny and the message of letting you pass shows. 2b. You accept and they join.

This way you can avoid having them if you don't want them to begin with.

Additional info

No response

LeHerosInconnu commented 2 years ago

@zenseii.

I suggest implementing an option in the dialog for alliance creatures. There would be some need for reworking of the logic and order of these dialogs.

Like this maybe:

  1. They offer to join and you get to choose yes or no and to look at your army 2a. You deny and the message of letting you pass shows. 2b. You accept and they join.

This way you can avoid having them if you don't want them to begin with.

Yes, I think a text like this could be added to the current text:

' "My lord, we would also be honored to join your army." Do you accept?'

In fheroes2:

Wandering join fh2 02

Similar discussion: https://github.com/ihhub/fheroes2/discussions/3309.

Branikolog commented 2 years ago

Could we use common text for joining here? image "The dwarves recognize their allies and gladly want to join your forces. "Do you accept?" In a case player refuses there would be nice to show the message, which is already implemented (or something similar, I'm concerning about "hail" here). image

zenseii commented 2 years ago

Could we use common text for joining here? "The dwarves recognize their allies and gladly want to join your forces. "Do you accept?" In a case player refuses there would be nice to show the message, which is already implemented (or something similar, I'm concerning about "hail" here).

I agree with the points above. You could remove the part before the quotation marks maybe, not sure if that would look weird.

LeHerosInconnu commented 2 years ago

Hello @Branikolog and @zenseii,

Could we use common text for joining here? image "The dwarves recognize their allies and gladly want to join your forces. "Do you accept?" In a case player refuses there would be nice to show the message, which is already implemented (or something similar, I'm concerning about "hail" here). image

I agree with the points above. You could remove the part before the quotation marks maybe, not sure if that would look weird.

Yes, this can work too. :)