ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.6k stars 365 forks source link

Crash at the end of player's turn #5399

Closed Branikolog closed 2 years ago

Branikolog commented 2 years ago

Preliminary checks

Platform

Linux

Describe the bug

Based on a feedback from one user. Not sure this bug is reproduceable, since player used quite an old save file, which was created a couple releases ago.

Crash log:

aust@Rizen53600 ~ [SIGABRT]> fheroes2
Free Heroes of Might and Magic II, version: 0.9.15
----------
Main Menu

Press N to choose New Game.
Press L to choose Load previously saved game.
Press H to show High Scores.
Press C to show Credits.
Press T to open Game Settings.
Press ESCAPE to Quit the game.
----------
10:17:35: [ERROR]       Play:  Couldn't open /etc/timidity++/freepats.cfg
10:18:24: [ERROR]       Play:  Couldn't open /etc/timidity++/freepats.cfg
10:18:26: [ERROR]       Play:  Couldn't open /etc/timidity++/freepats.cfg
10:18:28: [ERROR]       Play:  Couldn't open /etc/timidity++/freepats.cfg
10:18:29: [ERROR]       Play:  Couldn't open /etc/timidity++/freepats.cfg
fheroes2: ../fheroes2/kingdom/kingdom.cpp:486: const Recruits& Kingdom::GetRecruits(): Assertion `recruits.GetID1() != recruits.GetID2() && recruits.GetID1() != Heroes::UNKNOWN && recruits.GetID2() != Heroes::UNKNOWN' failed.
fish: Job 1, 'fheroes2' terminated by signal SIGABRT (Abort)
faust@Rizen53600 ~ [SIGABRT]> 

Save file

Unfortunately, no save file was provided by the user.

Additional info

No response

oleg-derevenetz commented 2 years ago

It looks like the game has run out of free heroes in the pool :) Too many jails on the map maybe? It's hard to say what exactly is wrong without a save file.

ihhub commented 2 years ago

No free heroes in free heroes 2...🤣

Branikolog commented 2 years ago

Player even couldn't reproduce the issue on a new game, actually. I've asked him to pay attention to this place and ping me, if it happens again. Let's keep the issue opened at least for a while.

ihhub commented 2 years ago

Closing this issue for now as not feedback was given for a very long time.