Polish rendering on Adventure Map

ihhub commented 1 year ago

Preliminary checks

[X] I've checked that there aren't other open issues on the same topic.

Describe the problem requiring a solution

After merging #5692 we still have multiple tasks to be done in order to polish rendering on Adventure Map:

[ ] standartise object fading animation including heroes
[x] remove old save formats (before 0.9.16? release)
[x] do not store image parts but rather image regions and flip flag and use them while rendering
[ ] rendering of monsters over Dragon City (added a TODO comment for it)
[x] rendering heroes / boats outside map while they are in fog
[ ] overlapping of boats during movement (froth should be rendered under another boat for some cases; perspective of boats)
[x] path icon should be removed after a hero makes a turn, not before
[x] some objects like flying ghosts over mines are not rendered if the main tile is below the rendering area

Good to have:

[ ] shadows of heroes must be drawn over other objects (tricky one. The original version does this but it breaks a lot of other places. For now we stick with common logic for all objects)

All issues related to rendering on Adventure Map should be reported here to make them easier to track.

Describe the possible solution

Fix everything.

Additional info

No response

Branikolog commented 1 year ago

An issue with wide tree: Tree.zip

ihhub commented 1 year ago

Hi @Branikolog , I think it works exactly the same way as in the original game due to object info.

oleg-derevenetz commented 1 year ago

It seems that Mine guards are no longer drawn (map "Skirmish"):

ihhub commented 1 year ago

Oh, no. I will fix it.

Branikolog commented 1 year ago

Hi @Branikolog , I think it works exactly the same way as in the original game due to object info.

Hi, @ihhub ! I suppose you're right. But nevertheless this bug should be fixed. ;)

Branikolog commented 1 year ago

{SOLVED} AI hero priority rendering bug: Decisions_Hero bug.zip

Edit: Fixed by #5787

Branikolog commented 1 year ago

Hi, @ihhub I've noticed that AI hero sprite is partially visible through mountains while moving. Horse tail.zip

Branikolog commented 1 year ago

{SOLVED} One more issue: Alchemist lab flag appears only when the roof is visible on the screen:

ihhub commented 1 year ago

Hi, @ihhub I've noticed that AI hero sprite is partially visible through mountains while moving.

Are you testing the latest version with my fix for AI heroes? If yes is it the same for player's heroes?

Branikolog commented 1 year ago

Are you testing the latest version with my fix for AI heroes? If yes is it the same for player's heroes?

Sorry, my little mistake: human heroes experience the same bug. I'm testing on the latest build of course. ;) Horse tail is visible through mountains for both human and AI heroes. I thought this bug was fixed recently... I must be wrong...

Branikolog commented 1 year ago

Oasis has an issue with a hero moving downwards. 198876878-b1dafec4-04a8-4c1c-a280-6d318cfcf12c Broken_Allian1.zip

LeHerosInconnu commented 1 year ago

The hero's shadow is added to the Water Wheel's shadow, making part of the shadow darker.

In fheroes2:

Shadows merge 01

Here is the save file: Shadows merge 01.zip

LeHerosInconnu commented 1 year ago

Some objects project a shadow on the hero as he moves.

In fheroes2:

https://user-images.githubusercontent.com/43583994/200311878-681206cb-9d0b-4cf4-93e8-ca506a65c492.mp4

Here is the save file: Shadow over hero 10.zip

Edit.

Other saves for this: Shadow over hero 10.zip

In fheroes2:

https://user-images.githubusercontent.com/43583994/200318834-aa8a6127-b057-4a70-abfd-53049e3842d8.mp4

https://user-images.githubusercontent.com/43583994/200318640-e1fd296f-290b-477e-abc2-352a71ca3c19.mp4

Branikolog commented 1 year ago

A part of hero sprite is still visible through obstacles on the adventure map.

https://user-images.githubusercontent.com/55348946/206858575-8bfb5f7a-cf62-46fb-8d36-b7eb7c70b916.mp4

Branikolog commented 1 year ago

One more case:

Unicorn tail.zip

Branikolog commented 1 year ago

One more issue with hero flag while going out of the castle: Cut flag

Branikolog commented 1 year ago

{SOLVED} Shadow is partly rendered over a boat sailing diagonally:

https://user-images.githubusercontent.com/55348946/221403910-18b7863b-3c40-45f2-aa2a-092b6f95305d.mp4

Districh-ru commented 1 year ago

{SOLVED} Hero shadow is not properly updated during move when hero speed is set to 10: fheroes2 2023-03-13 15-20-42-634 fheroes2 2023-03-13 16-05-08-805

Edit: Fixed by #6831

LeHerosInconnu commented 1 year ago

The bottom of the hero sprite is cut on the road.

In fheroes2:

Hero bottom sprite cut on road 01

Here is the save file (1.0.2 6820): Hero cut on road 01.zip

Districh-ru commented 1 year ago

The bottom of the hero sprite is cut on the road.

In this case the layer type for the Road is set to "Object layer". On the nearby tiles the Road layer type is "Terrain layer".

--------- Level 1 --------
UID             : 5318
ICN object type : 30 (ROAD.ICN)
image index     : 1
layer type      : 0 (0) - Object layer
is shadow       : no
--- Extra information ---

~~Maybe we should correct such cases on map load. Hi, @ihhub, what do you think?~~

Update: The original map does not have such issue. It happens on monster spawn at the start of the month. Initially this tile was:

******* Tile info *******
Tile index      : 14878, point: (46, 103)
UID             : 5318
MP2 object type : 0
ICN object type : 30 (ROAD.ICN)
image index     : 1 (animated: 0)
layer type      : 3 - Terrain layer

Edit: Fixed by https://github.com/ihhub/fheroes2/pull/6858

Branikolog commented 1 year ago

One more priority rendering bug which is present in the OG too. THUNK_crack.zip

Districh-ru commented 1 year ago

One more priority rendering bug which is present in the OG too. THUNK_crack.zip

It is probably a bug of original editor: ~when there is a Road or a Stream~ it can put some Shadow layer objects to the 2nd layer which are rendered after the render of heroes:

``` ******* Tile info ******* Tile index : 3342, point: (102, 30) UID : 1835 MP2 object type : 108 (Crater) ICN object type : 31 (MTNCRCK.ICN) image index : 0 (animated: 0) layer type : 2 - Shadow layer region : 22 ground : Wasteland (isRoad: 1) shadow : true passable from : center, top, top-right, right, bottom-right, bottom, bottom-left, left --------- Level 1 -------- UID : 1906 ICN object type : 30 (ROAD.ICN) image index : 18 layer type : 3 (3) - Terrain layer is shadow : no --------- Level 2 -------- UID : 5596 ICN object type : 57 (OBJNCRCK.ICN) image index : 226 layer type : 2 (2) - Shadow layer is shadow : no --- Extra information --- ************************* ```

The issue is the same as in https://github.com/ihhub/fheroes2/issues/5716#issuecomment-1220622843 (Updated save file: Tree.zip )

And the left part of the Tree has the same issue as the right one: fheroes2 2023-04-01 19-27-40-037

```******* Tile info ******* Tile index : 5491, point: (19, 38) UID : 0 MP2 object type : 99 (Trees) ICN object type : 0 (UNKNOWN) image index : 255 (animated: 0) layer type : 0 - Object layer region : 16 ground : Dirt (isRoad: 0) shadow : false passable from : center, top, right, bottom-right, bottom, bottom-left, left, top-left quantity 1 : 0 quantity 2 : 0 add. metadata : 0 --------- Level 2 -------- UID : 11996 ICN object type : 56 (OBJNDIRT.ICN) image index : 122 layer type : 0 (0) - Object layer is shadow : no --- Extra information --- ************************* ```

LeHerosInconnu commented 1 year ago

The red AI player's hero is displayed over the top of the Necromancer's castle.

In fheroes2:

AI hero over top castle 01