ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.69k stars 375 forks source link

[Controls] Hotkey Inconsistency Issues #6313

Closed JoLiKMC closed 1 year ago

JoLiKMC commented 1 year ago

Preliminary checks

Platform

Windows

Describe the bug

There's a lot of hotkeys in the original Heroes II that do various things. For example, hitting "F" will open the "File Menu" where one can load or save their game, quit, or start a new game. In any case, it seems like most of the hotkeys work as expected. However, there are two small problems I've noticed:

  1. If the player opens the File sub-menu and tries to use any of the expected hotkeys (N, Q, L, S) from within, they won't work.
  2. There is no "Quit Game" hotkey. At all. (Default "Q" in Heroes II.) 2b. However, in fheroes2, hitting Escape while on the Adventure Map does open the Quit Game prompt. This doesn't work in Heroes II.
  3. In the original version of the game, both H and Tab would select the next Hero with usable movement points. By default, fheroes2 only uses "H" for this.

Nothing earth-shattering. Just some observations.

oleg-derevenetz commented 1 year ago

If the player opens the File sub-menu and tries to use any of the expected hotkeys (N, Q, L, S) from within, they won't work.

What is the "File sub-menu"?

In the original version of the game, both H and Tab would select the next Hero with usable movement points. By default, fheroes2 only uses "H" for this.

This is configurable. Just set the next hero in the fheroes2.key to TAB. However, multiple hotkeys for the same action are not supported, you need to choose just one hotkey which you are more used to.

JoLiKMC commented 1 year ago

What is the "File sub-menu"?

File Sub-Menu This thing. Hitting Q from here does nothing whereas in the original game, it does something.

In the original version of the game, both H and Tab would select the next Hero with usable movement points. By default, fheroes2 only uses "H" for this.

This is configurable. Just set the next hero in the fheroes2.key to TAB. However, multiple hotkeys for the same action are not supported, you need to choose just one hotkey which you are more used to.

Also, to be fair, TAB opens the chat prompt in Heroes III rather than change heroes. And I'm guessing you're trying to emulate Heroes III for "consistency", or to "update the game to modern standards". If either of those are the case, then I guess it's fine as it is.

oleg-derevenetz commented 1 year ago

And I'm guessing you're trying to emulate Heroes III for "consistency", or to "update the game to modern standards".

Not quite - this is because the current implementation of hotkeys is made so that you cannot have more than one hotkey for one specific action. But, unlike the original HoMM2, you can choose the hotkey that you like best.

JoLiKMC commented 1 year ago

I feel obligated to point out: Q doesn't quit the game in Heroes III, either, but Escape does. So.

Once again… it's your project.

zenseii commented 1 year ago

I feel obligated to point out: Q doesn't quit the game in Heroes III, either, but Escape does. So.

Once again… it's your project.

Hi, @JoLiKMC. The point we're trying to make is that you can configure all the hotkeys in the game so you can decide if the exit hotkey should be q or w or 2.

As for adding a hotkey to that dialog, this is a fair point. I believe it might have been mentioned in #5270