ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.58k stars 359 forks source link

Support for .ogg CD audio tracks. #6648

Closed Barr-find closed 5 months ago

Barr-find commented 1 year ago

Preliminary checks

Describe the problem requiring a solution

In "Ubisofts Heroes I-IV Complete" ubisoft is using .ogg files to emulate CD Audio for their version of "Heroes 2 Gold". Those files just reside in "CD" Directory after game instalation. It would be nice to use those audio tracks in FHeroes2. I'm not the fan of MIDI music. Heroes2_OGG_Files

Describe the possible solution

Investigate tracks layout (imo it's same like on Heroes2 Gold CD) and add option to playback those .ogg files instead of standard .mid files.

Additional info

On same DVD release there is Heroes 2 Gold .iso file with all of the CD Audio tracks but FHeroes2 can't read them. Even if I mount this .iso into virtual drive FHeroes still play only .mid music. BTW Media Player is able to play those audio tracks without problem so??? Will You add CD Audio support to FHeroes2? Please!

undef21 commented 1 year ago

Hello @Barr-find. fheroes2 already supports ogg, flac and mp3 music. If you rename tracks to "Track02.ogg" and put them into "music" folder, you'll get CD music.

Barr-find commented 1 year ago

Ohh so less work for them. Their scripts (I think it's "extract_homm2_resources.bat") should detect .ogg files from "Ubisofts Heroes I-IV Complete" DVD edition, rename them and paste them in "music" folder --> "Job Done"! BTW: !!! Add info in Readme and on Wiki page about this !!!

TY @undef21 that was useful info. But that is not all. What about Audio tracks in .iso / .bin CD Images mounted into virtual drives? That would be nice improvement to.

oleg-derevenetz commented 1 year ago

@Barr-find since you (apparently) have all these assets, you are welcome to implement this and offer a PR.

undef21 commented 1 year ago

@Barr-find Is your "Heroes 2 Gold.iso" image of DOS version? That version used multitrack CD. In that case user needs to install additional software: a good CD emulator and a CDAudio ripper. Modern releases of HoMM 2 usually have ripped tracks.

ihhub commented 5 months ago

I'm closing this issue as the author of the topic vanished and doesn't respond.

Barr-find commented 5 months ago

Hello @Barr-find. fheroes2 already supports ogg, flac and mp3 music. If you rename tracks to "Track02.ogg" and put them into "music" folder, you'll get CD music.

This suggestion solved the issue! TY once more.