Some issue related to win/loss condidions

[Arthusppp]

Preliminary checks

• [X] I've checked that there aren't other open issues on the same topic.
• [X] I've checked that this issue is reproducible on the latest snapshot build.

Platform

Windows

Describe the bug

I believe there is some problem with win/loss conditions. This is rather minor thing, as the given situanion is far from a real one.

Starting from:

• Two teams: in the first one human blue player, in the second two AI players: orange and red
• None of player has town/castle since start (Month: 1, Week: 1, Day: 1)
• Now is Month: 1, Week: 2, Day: 1
• I press the End Turn button

What happens: Step#1: I can see the Defeat screen - so far, it is ok Step#2: the game continues, I can see that the Red player has been vanquished Step#3: the game continues, I can see that the Yellow player has been vanquished! Step#4: as enemy was beaten (!), my side won!!

In my opinion, the game should end by human defeat. I should not see steps 2-4.

A second question: not directly related to this issue: how precisely count seven days without a town or castle? I should have lost after the "Day: 7", right? As: 1st day: Day: 1 2nd day: Day 2 3rd day: Day 3 4th day: Day 4 5th day: Day 5 6th day: Day 6 7th: day: Day 7 <-- so here I was playing full week without a town/castle Today, game gives me full 8 days to play.

Save file

AUTOSAVE.zip

Additional info

No response

[oleg-derevenetz]

In my opinion, the game should end by human defeat. I should not see steps 2-4.

Formally, all players here are defeated at the next day (because lifetime until vanquish is measured in days, not in turns - the turn may be over, but the day is not over until the next day will come), so it should be in fact a draw, but there is no such thing as a draw in HoMM2. Now this situation is interpreted in favor of the human player (more precisely, in favor of the first human player in the turn queue): all your enemies "lose", so you sort of "win", but that's more a matter of taste, in principle, the opposite logic can be applied.

[Arthusppp]

because lifetime until vanquish is measured in days, not in turns - the turn may be over, but the day is not over until the next day will come

Ohhh. Meaning if I am purple, and the blue player is vanquished, then during my turn on the same day, but after blue's turn, I can still attack blue hero?

[oleg-derevenetz]

Ohhh. Meaning if I am purple, and the blue player is vanquished, then during my turn on the same day, but after blue's turn, I can still attack blue hero?

In current implementation - yes: the day is still not over, so blue player isn't vanquished yet. There is the same logic as with mana replenishment in castles: hero doesn't get the mana replenishment until the next day, even if his kingdom's turn is already over. I think this is a fairly logical mechanics.

[oleg-derevenetz]

A second question: not directly related to this issue: how precisely count seven days without a town or castle? I should have lost after the "Day: 7", right? As: 1st day: Day: 1 2nd day: Day 2 3rd day: Day 3 4th day: Day 4 5th day: Day 5 6th day: Day 6 7th: day: Day 7 <-- so here I was playing full week without a town/castle Today, game gives me full 8 days to play.

That's how it's done in the original game:

• At the end of your turn at 1-1-1, you will get this message:

so "next week" will in fact count starting from 1-1-2.

• At the beginning of your turn at 1-2-1, you will get this message:

and game will let you play your turn at 1-2-1 (i.e. day 8).

• At the end of your turn at 1-2-1, you will see this:

However, there is a difference: OG will remove your kingdom's heroes, mines, etc after the end of your turn (i.e. "in the middle" of day 8), while fheroes2 will do this after the end of the full day (and I personally think this is more correct behavior).

[Arthusppp]

I feel the OG has a problem here as well. If I lost last castle not 1-1-1, but later, I have seven turns to play, not eight. As per below screenshots: I lost a town during 1-1-6 turn. The first turn w/o castle is 1-1-7. I have been vanquished after 1-2-6 (so here I had 7 full days to play, not 8).

[oleg-derevenetz]

I feel the OG has a problem here as well.

Yes, day 1-1-1 is sort of "special" both in OG and in fheroes2.