search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.69k stars 375 forks source link

Castle thumbnail missing "X" after building #7178

Closed jasonbtiller closed 1 year ago

jasonbtiller commented 1 year ago

Preliminary checks

Platform

Linux

Describe the bug

In the castle building screen, after building the castle's thumbnail does not get the "X" in the right-hand corner indicating it can't have new building this turn. Only after leaving the castle overview and returning to the castle overview does the thumbnail get the "X" badge.

I am unable to attach files for some reason, so I can't provide images or a save file, but here's how I reproduce it:

  1. Start a new game.
  2. Open castle overview.
  3. Click on castle to bring up build window.
  4. Note that the castle thumbnail has no "X" in the right-hand corner.
  5. Build something, like the statue.
  6. You automatically return to the castle overview screen; note that the castle thumbnail has no "X" badge.
  7. Exit the castle overview window to the adventure window - now the castle thumbnail updates properly.

I believe that the castle thumbnail should receive the "X" badge as soon as you build something without having to return to the adventure screen.

Save file

I can't provide a save because Firefox isn't allowing me to attach files...

Additional info

No response

oleg-derevenetz commented 1 year ago

If you are talking about castle thumbnail on the adventure map screen, i.e. here:

buttons

then this is by design: no details of the adventure screen are updated (be it the state of castles, heroes, or kingdom resources) while any dialogs are open on top of it. For example, when you hire a hero in a castle, this hero also does not appear in the list of heroes on the adventure map screen until you close the castle dialog window. This is not a bug. At best, this issue can be considered as a low-priority improvement.

jasonbtiller commented 1 year ago

I concur, @oleg-derevenetz. After I was watching the behavior of my GoG HoMM2, I realized that this was the original behavior. Sorry to clutter up the issues list.

ihhub commented 1 year ago

The same as #2598.

ihhub commented 1 year ago

Closing as duplicate of #5976 .