ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.58k stars 359 forks source link

Resource extraction script does not run Dosbox for Ubisoft digital version #7305

Closed zenseii closed 1 year ago

zenseii commented 1 year ago

Preliminary checks

Platform

Windows

Describe the bug

The script extract_homm2_resources is not able to run DOSBox from Ubisoft's Heroes 2 and therefore the anim folder's contents are not copied to the fheroes2 installation directory. Folders like data and music are copied correctly.

Here are the key differences of the Ubisoft installation: dosbox.exe is found in root of Heroes 2, not within a folder called DOSBOX like for GOG. The images are called homm2.gog and homm2.inst the latter is different from GOG where it has the extension .ins.

Save file

No save file needed.

Additional info

No response

zenseii commented 1 year ago

Hi, @oleg-derevenetz. I have looked into this a bit because I own this version and because a user on Discord made me aware that the script did not successfully copy the anim files from this version of Heroes 2.

I'm not familiar enough with powershell to make the necessary changes for the script quickly and since you wrote this script I was hoping you could look into it.

One suggestion I have is that we run imgmount on homm2.gog instead of homm2.ins since this is the common denominator between these installations that come with DOSBox.