search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.72k stars 377 forks source link

"Summon boat" spell does not work if there are no boats built by the player #7562

Closed drevoborod closed 1 year ago

drevoborod commented 1 year ago

Preliminary checks

Platform

Linux

Describe the bug

Seems like boat summoning spell stopped working as expected for human players in 1.0.7.. Here is save game, where my first hero does have the spell and there are a lot of boats on the map, but none of them were anytime possesed by player's heroes. So, it's not possible to summon them. And after I built my own boat, I was able to summon it.

Save file

Dominion_0132.zip

Additional info

No response

oleg-derevenetz commented 1 year ago

Hi @drevoborod Hmm, so what's the issue then? I downloaded your save file and see that all the empty boats already belong to any of the AI players - most of them belong to the yellow player, but some to the orange player, etc. You cannot summon a boat belonging to another player. Also please keep in mind that AI can now use the Summon Boat spell on a par with you, so it is able to summon (and use) neutral boats placed on the map by the map's author.

drevoborod commented 1 year ago

You cannot summon a boat belonging to another player.

And the same behaviour was in the original game, right? Now I understand why I couldn't summon them that days I was playing the original! It always frustrated me.. Ok, so it's not a bug, but it looks weird for me.. Why on Earth do they remain belonging when noone uses them?? There are even neutral flags on them! So I suggest to remove this strange mechanics of belonging empty boats to anyone. Actually, in Heroes 3 it was removed - all boats can be summoned there. Maybe the issue should be converted to a feature request?

oleg-derevenetz commented 1 year ago

Actually, in Heroes 3 it was removed - all boats can be summoned there.

That's not really the case. You still cannot summon boats belonging to other players in HoMM3.

Maybe the issue should be converted to a feature request?

What would be the point of this feature request? To allow any free boat to be summoned? I believe this would severely break the game mechanics - especially now, when AI actively uses the Summon Boat spell.

drevoborod commented 1 year ago

What would be the point of this feature request? To allow any free boat to be summoned?

Exactly. It looks logical for me. Or at least mark such "belonging" boats with corresponding flag colour.

I believe this would severely break the game mechanics

Actually, I think that some strange mechanics should be broken :) But ok, it's up to you.

drevoborod commented 1 year ago

That's not really the case. You still cannot summon boats belonging to other players in HoMM3.

It's true, I've checked it.. Very disappointing.. But in Heroes 3 there is a workaround: Summon boat spell on expert level creates new boat if there are no boats available. And Heroes 2 lacks of such possibility.

oleg-derevenetz commented 1 year ago

Actually, I think that some strange mechanics should be broken :) But ok, it's up to you.

In fact, I'm thinking about the changes in the opposite direction - to not allow AI players to summon neutral boats at all. But for now it's just a thought.

drevoborod commented 1 year ago

I'm sure that if we have such concept as "possesion" of a boat, we definitelly need to mark them visually. At the time it's not clear why these boats cannot be summoned. We need to provide explanation to the player. The simpliest way seems to leave boat flags painted with player's colour. But it can confuse in separate way - at the time coloured flag means that there is a hero onboard. So it requires further discussion. And what definitely should be done - explanation should be added to spell description. Something like "Only unowned boats can be summoned (and how to distinguish which are owned, we won't tell you, muhaha!)" :)

oleg-derevenetz commented 1 year ago

I'm sure that if we have such concept as "possesion" of a boat, we definitelly need to mark them visually.

Then I suggest you to update the description and change the title of this issue to reflect your proposal, and then we can turn it to the request for improvement.

zenseii commented 1 year ago

Hi @drevoborod ! I believe there already exists an issue about flag color for ships, but I might be wrong.

drevoborod commented 1 year ago

Ok, so this issue can be closed.