ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.68k stars 373 forks source link

Combat screen, difference between medusa petrification sprites #7879

Open LeHerosInconnu opened 11 months ago

LeHerosInconnu commented 11 months ago

Preliminary checks

Describe the problem requiring a solution

Due to a constraint on the size of the spell sprite in the creature information window, the orientation of the sword has been changed in relation to the sprite of the petrication spell (medusa ability).

After playing around a bit and being confronted with this phenomenon, I have realized that something isn't quite right. It doesn't seem "natural", there's always this effect of difference that jumps out and becomes irritating.

I suggest reworking the sprite for the petrification spell so that the sword orientation is the same as in the sprite for the petrification spell in the creature information window.

In fheroes2:

Petrification sprite 01 Petrification sprite 02

Petrification sprite only 57 x 45 01 Petrification sprite only 34 x 34 02

Here is the save file: Alamar Troyan medusa 01.zip

Describe the possible solution

I suggest reworking the sprite for the petrification spell so that the sword orientation is the same as in the sprite for the petrification spell in the creature information window.

Additional info

Version 1.0.8 7767

Branikolog commented 11 months ago

Hi, @LeHerosInconnu ! The same occurs to some other spells: Haste Not sure that reworking all such sprites worth our time. Maybe, it would be better just to expand creature characteristics window, since we have also issues with free space there for other elements, what do you think?

LeHerosInconnu commented 11 months ago

Hello @Branikolog,

Hi, @LeHerosInconnu ! The same occurs to some other spells: Haste

In the case of the haste spell, the sword is also shorter, but the orientation of the sword remains the same. This is the only change proposed for the petrification sprite, that the sword has the same orientation.

Not sure that reworking all such sprites worth our time. Maybe, it would be better just to expand creature characteristics window, since we have also issues with free space there for other elements, what do you think?

Do you mean enlarging the size of the creature's information window, and by the same token possibly enlarging the size of the sprites for the spells? That would be a possibility, but the orientation of one of the two sprites would have to be redone anyway. And when will this happen? The proposed sprite change isn't something that's going to take a lot of work, or a lot of time, either. :)

Branikolog commented 11 months ago

@LeHerosInconnu

Do you mean enlarging the size of the creature's information window, and by the same token possibly enlarging the size of the sprites for the spells? That would be a possibility, but the orientation of one of the two sprites would have to be redone anyway.

That's what I was talking about: make window larger and show full-size icons.

The proposed sprite change isn't something that's going to take a lot of work, or a lot of time, either. :)

Since the team lack professional artists, I'm not sure that re-making a single sprite will take more time, comparing to expanding window, since we've already made some similar work on save lists or generation new windows...

LeHerosInconnu commented 11 months ago

@Branikolog.

@LeHerosInconnu

Do you mean enlarging the size of the creature's information window, and by the same token possibly enlarging the size of the sprites for the spells? That would be a possibility, but the orientation of one of the two sprites would have to be redone anyway.

That's what I was talking about: make window larger and show full-size icons.

I'm afraid that enlarging the window and using large spell sprites means really enlarging the window. Here's an example with the small spell sprites in the creature info window. It would also leave much less room for future new spells.

In fheroes2:

Spell sprites in creature window 01

The proposed sprite change isn't something that's going to take a lot of work, or a lot of time, either. :)

Since the team lack professional artists, I'm not sure that re-making a single sprite will take more time, comparing to expanding window, ...

The same goes for me, I'm not sure that re-making a single sprite will take more time, comparing to expanding window. For sure, changing a few dozen pixels on a single sprite will be faster than enlarging a window. :)

Edit.

Here are the save file and the test scenario file: Before test spell combat 01.zip

ihhub commented 11 months ago

There is no need to show all spells at the same time. We can allow to scroll among them.

oleg-derevenetz commented 11 months ago

We can allow to scroll among them.

I don't really know how to do this in the dialog box displayed when pressing and holding the right mouse button.