ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.65k stars 370 forks source link

Adventure map, the rapid change of focus on the heroes appears to be like a graphical flaw #8428

Open LeHerosInconnu opened 6 months ago

LeHerosInconnu commented 6 months ago

Preliminary checks

Describe the problem requiring a solution

In fheroes2, during the AI's turn, the rapid change of focus on the heroes appears to be like a graphical flaw.

This can already be seen for the other AI players in the example, notably with the actions related to the fog of war, but it's during the yellow AI player's turn that it's most noticeable.

The yellow AI player's hero Wilfrey moves into castle Blackfang. Next, the yellow AI player's Agar hero appears to interact with the Wrathmont hero. Then the Wilfrey hero moves again. But this happens so quickly that it appears to be a graphic flaw.

In fheroes2;

https://github.com/ihhub/fheroes2/assets/43583994/a780bf9f-f60b-49b3-8f76-ca4d8d568c66

Here is the save file: Ai turn move flash 20.zip

Describe the possible solution

A delay should be introduced after each hero action so that it doesn't look like a graphic display default.

Additional info

Related discution: https://github.com/ihhub/fheroes2/discussions/3009.

ihhub commented 6 months ago

I don't see any issues with this. You set the highest speed for AI which leads for this behavior. The original game doesn't have so fast (120FPS) movement for AI heroes. Also, the original AI never switches between heroes.

LeHerosInconnu commented 6 months ago

Hello @ihhub,

I don't see any issues with this. You set the highest speed for AI which leads for this behavior.

In the previous example, the "Enemy Speed" parameter was set to "8".

Even when the "Enemy Speed" parameter is set to "1", the problem remains. And even if it weren't, the fact that it's possible to set the game to different speeds shouldn't mean that what can be likened to graphical flaws can be allowed. The game must remain pleasing to the eye in all its possible uses.

In fheroes2: "Enemy Speed" set to "1":

https://github.com/ihhub/fheroes2/assets/43583994/304f216f-537a-4119-ba62-c6607ceed987

"Enemy Speed" set to "9":

https://github.com/ihhub/fheroes2/assets/43583994/49473782-a331-46ec-951e-6ffcea62f187

The original game doesn't have so fast (120FPS) movement for AI heroes. Also, the original AI never switches between heroes.

Here again, the fact that it's different from the original game doesn't allow to deliver a game that isn't well made in all its possible settings.

zenseii commented 6 months ago

Hi, all! Just to point out, the issue @LeHerosInconnu is talking about is the one that can be seen at around 27 second mark in the video above with Enemy Speed set to 1. It is a brief flicker which could indeed be mistaken for a graphical flaw.

LeHerosInconnu commented 3 months ago

Another save for this. When the hero enters the town.

In fheroes2:

https://github.com/ihhub/fheroes2/assets/43583994/5757b889-2845-41ed-aa06-694da77110a9

Here is the save file (1.1.0 8733): Graphic glitch 01.zip