ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.66k stars 373 forks source link

Use Class instead of race in the editor. #8557

Open Mr-Bajs opened 5 months ago

Mr-Bajs commented 5 months ago

Preliminary checks

Describe the problem requiring a solution

Shouldn't the usage of Class, as the game already uses be used instead of Race? Race is technically wrong, and potentially be political sensitive in some languages.

I'm refering to the new strings added to the editor. Both the editor and the game should use the same terminology, also i think there was a previous discussion about changing race into class, but i'll might remember wrong.

Click to change race: Hero's race:

Describe the possible solution

.

Additional info

No response

zenseii commented 5 months ago

@Mr-Bajs is correct here. The correct term in Heroes 2 according to the manual and in the game is Class for different types of heroes, and "Alignment" for different castle/creature types.

oleg-derevenetz commented 5 months ago

and "Alignment" for different castle/creature types.

IIRC it's not quite the case. "Alignment" is "good" or "evil" (in HoMM3 and later there is also "neutral" alignment, e.g. Stronghold or Conflux), while term "faction" can be used instead of "castle/town type".

zenseii commented 5 months ago

and "Alignment" for different castle/creature types.

IIRC it's not quite the case. "Alignment" is "good" or "evil" (in HoMM3 and later there is also "neutral" alignment, e.g. Stronghold or Conflux), while term "faction" can be used instead of "castle/town type".

Hi, @oleg-derevenetz. It's possible that Heroes 3 changed things but from my research into this topic earlier, there is this dialog which talks about a player's "primary alignment", in other words their primary type of castle: image

The "alignment" term is found again in the morale descriptor. Troops of 3 alignments: image

There's also a use of "hero type" and "castle type": image

image

"Faction" is only mentioned once in the manual, and also in a more proper usage IMO, which is when talking about division of some bigger group, like a "political faction" being a group within a group. This would somehow indicate that there is one overarching ruler in Enroth and that the Knight, Warlock, Sorceress etc. are all factions being controlled by this ruler and they fight to gain power. image

image

https://www.dictionary.com/browse/faction

As long as no one suggests the often heard but completely wrong "Fraction".

oleg-derevenetz commented 5 months ago

It's possible that Heroes 3 changed things

Well, maybe. In HoMM3, alignment It is a broader characteristic than just the town type (there are multiple town types of each alignment type), and the operation of some objects and bonuses from certain terrain types depend on it.

ihhub commented 5 months ago

Marking it for 1.1.1 release as this is a very minor issue at the moment.