Code cleanup for the future changes of map loading with more functionality

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.

https://ihhub.github.io/fheroes2/

GNU General Public License v2.0

2.58k stars 359 forks source link

Code cleanup for the future changes of map loading with more functionality #8751

Closed ihhub closed 1 month ago

ihhub commented 1 month ago

add more checks for map loading logic
move the code for map loading into separate functions that we will use separately for fh2m file loading as we won't need the code to set metadata
rename certain functions to show their purpose. Many of them are being used only for MP2 map format
fix invalid logic for setting random artifacts

Branikolog commented 1 month ago

Hi, @ihhub ! I'm not sure if it's related to the changes of random artifact logic you've made within this PR... But random artifacts tend to be distributed in a strange categories in the PR build (I mean Art1/Art2/Art3). Here I placed a bunch of artifact groups: And here how they appear in game: Central column is the strongest ones. Right column - the weakest. Left column - intermediate.

ihhub commented 1 month ago

Hi @Branikolog , this PR doesn't touch logic of random artifacts.

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud