ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.58k stars 360 forks source link

Combat screen, Ballista info window, take into account the captain/hero's attack for the displayed attack value of archers #8807

Open LeHerosInconnu opened 4 weeks ago

LeHerosInconnu commented 4 weeks ago

Preliminary checks

Describe the problem requiring a solution

In fheroes2, the attack value of the captain/hero is not added to the attack value of the archers in the ballista information window. In the original game, this is not the case either. I suggest that this be taken into account to display a value that really corresponds to the attack value.

In original game: (click to expand)
No mage guild built: ![Ballista info window 001](https://github.com/ihhub/fheroes2/assets/43583994/e27f6e6a-d089-44d1-a707-df95a9c81add) First mage guild level built: ![Ballista info window 002](https://github.com/ihhub/fheroes2/assets/43583994/78b67f8e-70fe-4198-aa51-06a5327fc024) Captain's quarters built, captain has 1 attack: ![Ballista info window 003](https://github.com/ihhub/fheroes2/assets/43583994/87c22810-3804-493e-9938-4b5acfd58175) Hero leads defense, hero has 3 attack: ![Ballista info window 004](https://github.com/ihhub/fheroes2/assets/43583994/160bf184-d3f3-4c41-9e4b-2111e4a9c82c)
In fheroes2: (click to expand)
No mage guild built: ![Ballista info window 005](https://github.com/ihhub/fheroes2/assets/43583994/593b9aa3-68ad-4ddc-84bf-56a3992c2850) First mage guild level built: ![Ballista info window 006](https://github.com/ihhub/fheroes2/assets/43583994/c513ae2a-7052-40c0-91ff-0b73af527bd9) Captain's quarters built, captain has 1 attack: ![Ballista info window 007](https://github.com/ihhub/fheroes2/assets/43583994/d40dc672-f06a-4b76-99e5-e56331bd180f) The text should display an attack bonus of 1 + 1 = 2. ![Ballista info window 008](https://github.com/ihhub/fheroes2/assets/43583994/1abcda80-bcc5-4f46-8c0e-6b43805289a2) Hero leads defense, hero has 3 attack: ![Ballista info window 009](https://github.com/ihhub/fheroes2/assets/43583994/6db3f0f1-9104-44cb-9bb3-be7fdd2bdadd) The text should display an attack bonus of 1 + 3 = 4. ![Ballista info window 010](https://github.com/ihhub/fheroes2/assets/43583994/4dd7c843-537f-4528-b76d-c01d1e98ad47)

Here is the test scenario file: 0 9905.zip

Describe the possible solution

Display the value that really corresponds to the attack value.

It should be:

In the example, with the captain: "The Ballista fires... ...with a +2 bonus to their attack skill." "The Left Turret fires... ...with a +2 bonus to their attack skill." "The Right Turret fires... ...with a +2 bonus to their attack skill." Note that the captain has a different attack value depending on the type of castle.

In the example with the hero: "The Ballista fires... ...with a +4 bonus to their attack skill." "The Left Turret fires... ...with a +4 bonus to their attack skill." "The Right Turret fires... ...with a +4 bonus to their attack skill."

Additional info

No response