Add an ability to edit Rumors for maps

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.

https://ihhub.github.io/fheroes2/

GNU General Public License v2.0

2.58k stars 360 forks source link

Add an ability to edit Rumors for maps #8823

Closed ihhub closed 2 weeks ago

ihhub commented 2 weeks ago

close #8714

Branikolog commented 2 weeks ago

Hi, @ihhub I've found out that after pressing OK or Cancel in the rumor creating dialog there's a short delay, before dialog disappears.

I do also believe, that tavern window is not really large to keep long texts. Currently, It seems that I can create really long (is there any restrictions at all?) message, that is going not to fit the tavern window. In this case there's no way to even check, what is hidden after "..."

ihhub commented 2 weeks ago

Hi @Branikolog , I've reduced the sentence limit to 200 characters and also expanded the window:

Branikolog commented 2 weeks ago

Hi, @ihhub !

and also expanded the window:

Making window larger does not fix the problem with text editing and looks not really nice in my opinion.

Can we use here a window with larger field to edit rumors? Currently it is impossible to read and edit long messages. Something similar to map description for instance:

The problem with delayed window shutdown is still on.

ihhub commented 2 weeks ago

Hi @Branikolog , I've addressed your comments.

sonarcloud[bot] commented 2 weeks ago

Quality Gate failed

Failed conditions
24.4% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud