Add support of editing daily events within the Editor

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.

https://ihhub.github.io/fheroes2/

GNU General Public License v2.0

2.58k stars 360 forks source link

Add support of editing daily events within the Editor #8858

Closed ihhub closed 5 days ago

ihhub commented 1 week ago

add support for editing daily events within the Editor
allow to enter negative values for resources (Adventure Map events and daily events). Use - (minus) on your keyboard to swap between negative and positive values
fix cases when changing the value by mouse and then modifying it by keyboard resets the value
fix incorrect UI element layout for entering values. Now it follows the same layout as in the monster hiring window
fix text rendering in Adventure Map event window
add checks to skip events that will never trigger during gameplay

close #8713

Branikolog commented 1 week ago

Hi, @ihhub I'm testing this PR now. I managed to initiate an application crash when trying to type "space"+"Enter"(new line)+confirm in the event text field. The crash occurs for all other dialogs of the following type:

Should I create a separate issue for this case?

Branikolog commented 1 week ago

"-" mark is rendered out of the field range for large numbers:

There're also a few white pixels left after the case:

ihhub commented 1 week ago

Hi @Branikolog , please create a separate issue regarding the text editing. This PR is way too big.

Branikolog commented 1 week ago

Hi, @ihhub Now it is better, but some digits are still over the field frames: Maybe we can just place "-" sign to the left of the field, so it never overlaps UI elements? Maybe we can place it into a special checkbox or something like that?

ihhub commented 1 week ago

@Branikolog , we can simply don't allow to enter less than -99999 and no more than 999999 resources. This is UI issue and should be addressed separately.

Branikolog commented 1 week ago

It would be nice to show the exact day (month, week, day) near this counter. Everything else seem to work properly. 👍

ihhub commented 1 week ago

It would be nice to show the exact day (month, week, day) near this counter. Everything else seem to work properly. 👍

This is an improvement for the future.

sonarcloud[bot] commented 5 days ago

Quality Gate failed

Failed conditions
23.1% Duplication on New Code (required ≤ 5%)
15 Duplicated Blocks on New Code (required ≤ 10)

See analysis details on SonarCloud