ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.73k stars 377 forks source link

Combat, Surrender with only elemental creatures summoned with summon elemental spells #9070

Open LeHerosInconnu opened 2 months ago

LeHerosInconnu commented 2 months ago

Preliminary checks

Describe the problem requiring a solution

During combat, the player should be informed that a troop is made up of elemental creatures summoned with one of the summon elemental spells, and that they will disappear at the end of the combat. This can be indicated in the creature information window by putting in brackets behind the number of creatures the number of creatures actually retained at the end of the combat. In the example: "6 (0)", "(0)" indicating 0 creatures retained, as they are only temporarily present due to the summon elemental spell. Image is for explanation only.

Elemental surrender 002 01

In this case, when the hero wishes to surrender in a combat situation on open ground, the text should be adapted as follows:

"Natasha states: "It wouldn't be honest for me to ask you gold for troops you wouldn't keep, but I can accept to let you escape." "

Instead of:

"Natasha states: "I will accept your surrender and grant you and your troops safe passage for the price of 1 gold." "

Elemental surrender 001

In this case, when the defending hero wishes to surrender during a siege (as the hero cannot flee during a siege), the text should be adapted as follows:

"Natasha states: "I will accept your surrender and grant you safe passage for the price of 1 symbolic gold." "

Instead of:

"Natasha states: "I will accept your surrender and grant you and your troops safe passage for the price of 1 gold." "

Also, in the case of a surrender with only summoned elemental creatures, the hero should appear in the tavern with standard creatures, not just one level 1 creature.

In fheroes2:

Elemental surrender 003

https://github.com/user-attachments/assets/3d54d88a-7ca6-4ccf-808b-cd2abac4b5c0

Describe the possible solution

"Natasha states: "It wouldn't be honest for me to ask you gold for troops you wouldn't keep, but I can accept to let you escape." "

Instead of:

"Natasha states: "I will accept your surrender and grant you and your troops safe passage for the price of 1 gold." "

If the player clicks on the "ACCEPT" button, the hero escapes without paying gold.

2) In this case, when the defending hero wishes to surrender during a siege (as the hero cannot flee during a siege), the text should be adapted as follows:

"Natasha states: "I will accept your surrender and grant you safe passage for the price of 1 symbolic gold." "

Instead of:

"Natasha states: "I will accept your surrender and grant you and your troops safe passage for the price of 1 gold." "

If the player clicks on the "ACCEPT" button, the hero escapes, paying 1 gold.

3) In the case of a surrender with only summoned elemental creatures, the hero should appear in the tavern with standard creatures, not just one level 1 creature.

Additional info

Related issue: https://github.com/ihhub/fheroes2/issues/9058.

zenseii commented 2 months ago

Hi, @LeHerosInconnu.

I agree there's a need for this info in case a battle has gone on for a while and you forget which of your elementals were summoned and which weren't.

However, just a number in brackets is not intuitive. What if we just add a text under the name of the creature which says (summoned). This would remove any doubt.

LeHerosInconnu commented 2 months ago

Hello @zenseii,

Hi, @LeHerosInconnu.

I agree there's a need for this info in case a battle has gone on for a while and you forget which of your elementals were summoned and which weren't.

However, just a number in brackets is not intuitive. What if we just add a text under the name of the creature which says (summoned). This would remove any doubt.

I've used the same indication as for a troop of creatures temporarily resurrected with the resurrect spell (https://github.com/ihhub/fheroes2/issues/9058), but it's also possible to indicate this with text. You should be aware, however, that this means additional translation work for all languages. :)

I also think that the zero in brackets could be displayed too, it would give an additional, and more quickly visible, way than having to read the text under the creature's name.

Should we also specify this for creatures temporarily resurrected with the resurrect spell? With text like "Some creatures temporarily resurrected". Or "Some temporarily resurrected".

Without indicating the text under the name in the creature's right-click information window, it would also be possible to display a text window explaining the number in brackets when the user right-clicks on the field displaying the number of creatures in the troop. This would keep the window not too overloaded with extra text.

Edit.

It would also be possible to add "graphic brackets":) on either side of the creature sprite, as is the case for the spell sprite in the magic book (in addition to the zero in brackets for the number of creatures). This would avoid the need for additional text translations.

In fheroes2:

Summon element spell 01