ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.68k stars 375 forks source link

Combat screen, Auto combat and Instant Combat windows, change the text for better understanding #9094

Open LeHerosInconnu opened 1 week ago

LeHerosInconnu commented 1 week ago

Preliminary checks

Describe the problem requiring a solution

When the user presses the "Q" key on the keyboard (to instantly resolve the combat and exit the combat screen), a window is displayed to allow him to validate his action or not. However, the text is not clear.

Describe the possible solution

In fheroes2:

Auto and instant combat modes 001

I suggest displaying the following text:

"Are you sure you want to resolve the combat in instant combat mode?"

Instead of:

"Are you sure you want to finish the battle in auto mode?"

I also suggest changing the text of the window displayed when the user presses the “AUTO” button to continue the combat in automatic mode.

In fheroes2:

Auto and instant combat modes 002

I suggest displaying the following text:

"Are you sure you want to enable the auto combat mode?"

Instead of:

"Are you sure you want to enable auto combat?"

And to change the text of the window displayed when the user presses the “AUTO” button to interrupt the combat in automatic mode.

In fheroes2:

Auto and instant combat modes 002a

I suggest displaying the following text:

"Are you sure you want to interrupt the auto combat mode?"

Instead of:

"Are you sure you want to interrupt the auto combat?"

Additional info

No response

oleg-derevenetz commented 1 week ago

I have to explain the difficulty with this proposal (and with #9095). We already have the "finish the battle in auto mode" hotkey definition in the fheroes2.key, and if the wording in the game and in the hotkey config file will differ significantly, this may confuse the user. At the same time, the configuration files must remain backward compatible, so we can't just change the wording back and forth without further thought. The same applies to other similar hotkey-related actions.

LeHerosInconnu commented 1 week ago

I have opened a related discussion to this: https://github.com/ihhub/fheroes2/discussions/9100.