search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.74k stars 377 forks source link

Do not download the wing32.dll for HoMM2 demo version #9222

Closed oleg-derevenetz closed 1 month ago

oleg-derevenetz commented 1 month ago

I have no idea why we are downloading some 3-rd party DLL on Windows along with the demo version. This was done back when BAT script was used, and I suppose that H2DEMOW.EXE somehow requires this DLL, but the main purpose of the demo version download script is to gain access to the demo version assets in order to run fheroes2 with them. It is not intended to provide the user with the opportunity to directly play the original HoMM2 demo. IMHO we should not download some questionable DLL files to the user's computer.

zenseii commented 1 month ago

@oleg-derevenetz, it's possible to get only specific files from the zip archive too: https://ia600203.us.archive.org/view_archive.php?archive=/5/items/HeroesofMightandMagicIITheSuccessionWars_1020/h2demo.zip

The best would be to only download heroes2.agg and brokena.mp2.

Edit: perhaps also the license?

oleg-derevenetz commented 1 month ago

it's possible to get only specific files from the zip archive too

This would be suboptimal. ZIP archive has ~20 mb in size, while uncompressed HEROES2.AGG has ~42 mb in size, so it's better and faster to download the whole ZIP. But downloading some 3-rd party DLL is a bit too much.

ihhub commented 1 month ago

@oleg-derevenetz , thank you so much for this update! It's time to remove this file as demo isn't helpful anymore.