Open felix-schneider opened 3 days ago
After further discussion on discord, I decided to go back and compare the translations more closely against the original game. Please don't merge this yet.
Hi @felix-schneider , in the future if you would like to prevent a pull request being merged you can use Convert to draft
option which does this and also indicates that the pull request needs some work.
Once all work is done you can use the Ready to review
button.
Notes:
%{count} unit
(singular), so if that amount ever changes, the string needs to be edited anyway, so why bother having it?\u0022
or more correctly\u201C
and\u201D
) at the start and end of a direct quote. In German, at the start of a quotation, you would use the "low double comma"\u201E
at the start and upper double quotes\u201C
at the end. Both of those can be represented in CP1252 (0x84
and0x93
, respectively), but sadly it looks like the in-game font has no glyphs for them. The OG seems to actually use single quotes (actually apostrophes,\u0027
) in some cases (e.g. the spell scroll). I have not followed this example and used\u0022
instead.