search

ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.65k stars 370 forks source link

"Lightning" spell polishing #973

Open Branikolog opened 4 years ago

Branikolog commented 4 years ago

"Lightning" spell ,recently re-created by fheroes2 team, has become almost perfect. I think, a few mini enhancements here would make this spell ideal, and close to real lightning. In my opinion, appearing animation should happen much faster. Also I've noticed, that currently lightning disappears after being fully drawn. In the OG it seems to me, that lightning persists a few milliseconds, after being completely drawn. Also, I suggest to make lightning a little thicker. With all these changes and #969 and #972 it will become perfect...

Branikolog commented 4 years ago

Good work, @idshibanov. But no need flashes for every hit of "Chain Lightning" spell. Just for the first target.

ihhub commented 3 years ago

Hi @Branikolog , could you please update this issue?

Branikolog commented 3 years ago

@ihhub OK, I'll take a look at a current state of this problem in a few hours.

Branikolog commented 3 years ago

Well, "Lightning" spell works quite good currently... Lightning itself looks a bit different, but I like it more, than in original.. Original: Lightning original fheroes2: Lightning 2 Probably, we can try to make it a little thicker on the whole length (not much. 1px will be enough), but this is not necessary and debatable.

Comparing with an original animation I noticed a few places, that can be improved. We should reduce a bit the time of drawing between hero and target. In the original game it appears almost instantly. This can cause spell animation last too short. Here we can hold completely drawn lighting a few milliseconds more. I'm not sure, if we need screen flashing during this hold... I think without will be ok, but this need to be examined.