search

ihhub / penguinV

Computer vision library with focus on heterogeneous systems
Other
118 stars 90 forks source link

Base class for geometric shifted ellipse #327

Open ihhub opened 5 years ago

ihhub commented 5 years ago

We have a place where we store all mathematical base classes in src/math/math_base.h file. We would like to add a base class to represent an ellipse (a circle in some cases).

  1. Call new class as EllipseBase2D.
  2. Constructor of the class would receive a container of 2D points
  3. Internally we need to calculate ellipse parameters such as center position and two radiuses
  4. We could create another derived class for CircleBase2D which has only center position and one radius
  5. Add shift function to move center position of ellipse
  6. Add functions to return center and radiuses

To find ellipse parameters you need to use existing ellipse formula in Cartesian coordinates. To find parameters you could use a list of equations of first derivative in square. To remove unneeded points please use iterative method.

sethsawant commented 5 years ago

Hi, I'm interested in contributing, would this be a good first issue to tackle?

ihhub commented 5 years ago

Hello @sethsawant you could try to take it, no harm in this. If you need more explanation I can provide it. Mostly we need to implement math based functions within the new class.

ihhub commented 5 years ago

We do not force people to make a perfect solution from first shot. If you have your own design and idea then you could create a pull request for further discussion. I'll message in a couple of hours with my vision of implementation.

ihhub commented 5 years ago

@sethsawant if you think that this issue is little big I'll point to simpler issues. It's not a problem. Not all issues are marked 100% properly by labels. I'm apologizing for this

sethsawant commented 5 years ago

I think I would need a little more detail on what the implementation of this issue would involve, but I would definitely be interested in anything else that needs to be done!

ihhub commented 5 years ago

We have multiple issues for newcomers: Math issues: #269, #320, UI issues: #282, #313, #294 Documentation issues (no coding required): #296, #262 Scripting issues: #253

What I recommend is to try #269 at the start as it's quite simple to do ;)

ihhub commented 5 years ago

@sethsawant please let us know which task you choose to work on so then nobody would do double work :)

ihhub commented 5 years ago

Hi @sethsawant I've updated the description of this issue to be more clear what to do.

ihhub commented 5 years ago

Hello @sethsawant have you pick up any issue? :)