ihmcrobotics / euclid

Vector math, geometry, reference frame, and shapes 2D & 3D
Apache License 2.0
31 stars 9 forks source link

`FramePose3DBasics` should override `FixedFramePose3DBasics#set(ReferenceFrame, Pose3DReadOnly)` #59

Closed calvertdw closed 1 year ago

calvertdw commented 1 year ago

FixedFramePose3DBasics#set(ReferenceFrame, Pose3DReadOnly) throws an exception if the referenceFrame passed in is different, which makes sense for a fixed frame object. But very often, what you've actually got is a non-fixed frame pose, and the set(ReferenceFrame, Pose3DReadOnly) could be more helpful by figuring it out instead. This is pretty much just a setIncludingFrame and changeFrame back to the original.

SylvainBertrand commented 1 year ago

Ok what you're describing is setMatchingFrame(...) and yeah there are quite a few missing for that class. I'll add them

SylvainBertrand commented 1 year ago

That's on develop, will be in the next release

calvertdw commented 1 year ago

Thanks!