When compositeSearchHeight and excludeFromCompositeBuild are set wrong, useless NullPointerException

ihmcrobotics / ihmc-build

Composite build and IDE classpath seperation support for JVM Gradle projects.

Apache License 2.0

5 stars 4 forks source link

When compositeSearchHeight and excludeFromCompositeBuild are set wrong, useless NullPointerException #63

Open jespersmith opened 6 years ago

jespersmith commented 6 years ago

Steps to reproduce issue

Check out a project that does not depend on any other source project
Set compositeSearchHeight to 1 and excludeFromCompositeBuild to false
Run gradle build

Expected behavior

A useful error that tells the user what is wrong

Actual behavior

FAILURE: Build failed with an exception.

* What went wrong:
java.lang.NullPointerException (no error message)

Contributors with relevant knowledge or expertise (optional)

@calvertdw

calvertdw commented 6 years ago

Just to confirm, which version are you using?

jespersmith commented 6 years ago

ihmc-java-ros2-communication uses "us.ihmc:ihmc-build:0.14.0"

calvertdw commented 6 years ago

Okay, thanks. I'll fix in the next release.

calvertdw commented 5 years ago

Putting this here for my notes.

Find origin of NPE
Handle that situation without crashing
Depending on what it is, either warn or continue silently

calvertdw commented 5 years ago

@jespersmith This must be a result of a specific situation where it tries to search the 1 height and NPEs on something. I cannot reproduce. If you give me the full stack trace I can add a NPE check.

calvertdw commented 5 years ago

Did not mean to close that.