search

ihmeuw-msca / pyDisagg

BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Functional rewrite #28

Closed AHsu98 closed 1 year ago

AHsu98 commented 1 year ago

Overall rewrite to clean up and make it more functional. Before, everything was a bit overcomplicated and wrapped up in classes. Generally trying to just pass things around here rather than making them class attributes.

AHsu98 commented 1 year ago

@kels271828 I agree with the idea of separating features from refactoring, but I got confused when I was trying to fix/add features first (before I realized I should try to refactor), which is where this whole rewrite idea came from. I'll add some more comments after I finish this on what exactly has changed, and explaining feature vs refactoring differences.

AHsu98 commented 1 year ago

Oh I just remembered I missed some linting type stuff, and was going to make another commit from what @kels271828 had mentioned above, but besides that, we are all set here.

AHsu98 commented 1 year ago

Alright, I think we should be all set here! @kels271828 @zhengp0 @saravkin @rsoren , I should be ready to merge now. I don't think we need much more review on this, I'd like to put any other changes on later updates.

AHsu98 commented 1 year ago

Had a quick chat with sasha, going to go ahead and just force merge this now.