changes to workflow.py sql query pass all nox client tests

ihmeuw-scicomp / jobmon

Other

3 stars 6 forks source link

changes to workflow.py sql query pass all nox client tests #119

Closed Kevinoh47 closed 4 months ago

Kevinoh47 commented 4 months ago

when an inner WHERE clause is not provided the current code is throwing this error:

(MySQLdb.ProgrammingError) (1064, "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')\n GROUP BY\n workflow_id, queue_id\n ' at line 32")

everdyke commented 4 months ago

I'm slightly surprised this error is still popping up with this check in place: https://github.com/ihmeuw-scicomp/jobmon/blob/release/3.2/jobmon_server/src/jobmon/server/web/routes/v2/cli/workflow.py#L474-L477

That being said, I'm good with this fix. I wonder if we should delete line 474-477 though

github-actions[bot] commented 4 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
jobmon_server/src/jobmon/server/web/routes/v2/cli
workflow.py					523-526
Project Total

This report was generated by python-coverage-comment-action

github-actions[bot] commented 4 months ago

Test Results

220 tests ±0 215 :white_check_mark: ±0 18m 32s :stopwatch: ±0s 1 suites ±0 5 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit 1696aa82. ± Comparison against base commit 8fc7683e.