Ko dd-5444 - Githubissues

ihmeuw-scicomp / jobmon

Other

3 stars 6 forks source link

Ko dd-5444 #128

Closed Kevinoh47 closed 1 month ago

Kevinoh47 commented 3 months ago

sorry this took so long to create a PR. I have to log into github using kevinoh_ihme to use copilot, and didn't realize that i had to be signed in as my personal github account to open a PR on ihmeuw-scicomp/jobmon.

github-actions[bot] commented 3 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
jobmon_server/src/jobmon/server/web/routes/v2/fsm
array.py					58-67, 93-107, 201-213, 223-227, 232-248, 269-311
Project Total

This report was generated by python-coverage-comment-action

github-actions[bot] commented 3 months ago

Test Results

220 tests ±0 215 :white_check_mark: ±0 18m 31s :stopwatch: -1s 1 suites ±0 5 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit bcff6382. ± Comparison against base commit ca43a069.

:recycle: This comment has been updated with latest results.

Kevinoh47 commented 3 months ago

@mlsandar so far i have not been able to get any version of the above to pass the unit tests, though I am still working on it.
May I ask your motivation for the suggested change?

Kevinoh47 commented 3 months ago

OK @mlsandar I hope this change addresses both the need for sql agnosticism and prevention of sql injection.