Mic 4277/update 1040 obs

ihmeuw / vivarium_census_prl_synth_pop

US Census Probabilistic Record Linkage synthetic population generation

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

Mic 4277/update 1040 obs #307

Closed albrja closed 1 year ago

albrja commented 1 year ago

Mic-4277/update 1040 obs

Updates 1040 observer to fix sampling bugs.

Category: Bugfix
JIRA issue: MIC-4277
Research reference:

Changes and notes

-Adds sampling to replace income sampling at flat rate -Fixes bug with joint filing eligibility.

Verification and Testing

Successfully ran simulation.

albrja commented 1 year ago

@stevebachmeier Yes I ran test suites. I think the unit test is a good idea but I'm hesitant right now because at some point we will add income as our sampling factor for who files taxes. I'm unsure where we will do that - whether is in this same spot or if we can filter later in pseudopeople.