ihmwg / python-ihm

Python package for handling IHM mmCIF and BinaryCIF files
MIT License
14 stars 7 forks source link

Add jPOSTrepo to location.py #109

Closed brindakv closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #109 (ead04ed) into main (2330546) will decrease coverage by 0.02%. The diff coverage is 75.00%.

:exclamation: Current head ead04ed differs from pull request most recent head 699d8bb. Consider uploading reports for the commit 699d8bb to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/ihmwg/python-ihm/pull/109/graphs/tree.svg?width=650&height=150&src=pr&token=J0QoOLwwXv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ihmwg)](https://codecov.io/gh/ihmwg/python-ihm/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ihmwg) ```diff @@ Coverage Diff @@ ## main #109 +/- ## ========================================== - Coverage 99.76% 99.75% -0.02% ========================================== Files 29 29 Lines 7231 7235 +4 Branches 1736 1737 +1 ========================================== + Hits 7214 7217 +3 - Misses 11 12 +1 Partials 6 6 ``` | [Impacted Files](https://codecov.io/gh/ihmwg/python-ihm/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ihmwg) | Coverage Δ | | |---|---|---| | [ihm/location.py](https://codecov.io/gh/ihmwg/python-ihm/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ihmwg#diff-aWhtL2xvY2F0aW9uLnB5) | `99.17% <75.00%> (-0.83%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/ihmwg/python-ihm/pull/109?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ihmwg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ihmwg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/ihmwg/python-ihm/pull/109?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ihmwg). Last update [2330546...699d8bb](https://codecov.io/gh/ihmwg/python-ihm/pull/109?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ihmwg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ihmwg).
brindakv commented 1 year ago

Looks good to me, just needs the new class to be added to docs/location.rst and a basic test of the constructor added to test/test_location.py. See 7a45a8a for an example.

Thanks @benmwebb. Do you want the version to be updated as well?