ihmwg / python-ihm

Python package for handling IHM mmCIF and BinaryCIF files
MIT License
14 stars 7 forks source link

Database location names should follow controlled vocabulary #116

Closed aozalevsky closed 1 year ago

aozalevsky commented 1 year ago

Database names are stored in the controlled vocabulary. Thus if a user uses a generic class ihm.location.DatabaseLocation and assigns a custom db_name (as recommended in the docs)

Alternatively the resource may be found in an experiment-specific 
database such as PDB or EMDB - for this use [DatabaseLocation] or one of its subclasses.

, the resulting mmcif file won't pass the validation. The generic ihm.location.DatabaseLocation should have name OTHER and be protected from overwriting.

benmwebb commented 1 year ago

Agreed, this is kind of a holdover from the early days of the dictionary when the database table was in flux.