ihmwg / python-ihm

Python package for handling IHM mmCIF and BinaryCIF files
MIT License
14 stars 7 forks source link

Change _ihm_chemical_descriptor to _ihm_chemical_component_descriptor in dumper.py #41

Closed CAHanke closed 5 years ago

CAHanke commented 5 years ago

According to the IHM-dictionary, the "_ihm_chemical_descriptor" category should be called "_ihm_chemical_component_descriptor" in dumper.py

benmwebb commented 5 years ago

@brindakv You called this category ihm_chemical_descriptor in the CX-chemical-descriptors branch but @CAHanke is correct in that it's called ihm_chemical_component_descriptor in the master branch. I can change the name in python-ihm of course if this is intentional.

brindakv commented 5 years ago

@benmwebb Yes, it is intentional. Please update accordingly. I will delete the CX-chemical-descriptors branch.