search

ihmwg / python-ihm

Python package for handling IHM mmCIF and BinaryCIF files
MIT License
14 stars 7 forks source link

Explain ihm.Citation parametrs a bit clearer. #73

Closed bienchen closed 2 years ago

bienchen commented 2 years ago

Hello Ben,

I extended the documentation of ihm.Citation a bit. Background is that SWISS-MODEL's latest publication was in the NAR web server issue and NAR adds 'W' to the numbers. I found that using str instead of int works with ihm.Citation for volume and page_range, so I added that to the help text.

Stefan

codecov-commenter commented 2 years ago

Codecov Report

Merging #73 (1e41278) into main (c398982) will decrease coverage by 2.87%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   99.69%   96.82%   -2.88%     
==========================================
  Files          28       27       -1     
  Lines        6977     6369     -608     
  Branches     1658     1531     -127     
==========================================
- Hits         6956     6167     -789     
- Misses         15      181     +166     
- Partials        6       21      +15
Impacted Files Coverage Δ
ihm/__init__.py 99.78% <ø> (ø)
ihm/format.py 49.86% <0.00%> (-50.14%) :arrow_down:
ihm/util.py 92.85% <0.00%> (-7.15%) :arrow_down:
ihm/reader.py 99.37% <0.00%> (-0.38%) :arrow_down:
ihm/dumper.py 99.61% <0.00%> (-0.20%) :arrow_down:
ihm/geometry.py 100.00% <0.00%> (ø)
src/ihm_format.c

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c398982...1e41278. Read the comment docs.