search

ihmwg / python-ihm

Python package for handling IHM mmCIF and BinaryCIF files
MIT License
14 stars 7 forks source link

Add support for _struct.pdbx_model_details #80

Closed bienchen closed 2 years ago

bienchen commented 2 years ago

For ModelArchive we need the _struct.pdbx_model_details field. I tried to add it to ihm by extending ihm.System and the struct dumper. Unit tests were also adapted by creating file output and running diff to make sure that just the _struct.pdbx_model_details line was added. Documentation builds and shows the changes.

codecov-commenter commented 2 years ago

Codecov Report

Merging #80 (cecb7fa) into main (8aa374a) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          28       28           
  Lines        7014     7015    +1     
  Branches     1663     1663           
=======================================
+ Hits         6998     6999    +1     
  Misses         13       13           
  Partials        3        3
Impacted Files Coverage Δ
ihm/dumper.py 100.00% <ø> (ø)
ihm/__init__.py 99.78% <100.00%> (+<0.01%) :arrow_up:
ihm/reader.py 99.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8aa374a...cecb7fa. Read the comment docs.