search

ihmwg / python-modelcif

Python package for handling ModelCIF mmCIF and BinaryCIF files
MIT License
9 stars 1 forks source link

Add _ma_target_ref_db_details.[seq_db_sequence_version_date, seq_db_sequence_checksum] #15

Closed bienchen closed 2 years ago

bienchen commented 2 years ago

Add two more data items to _ma_target_ref_db_details. The version date is kept as datetime.date object, allowing python-modelcif to apply the right formatting. The CRC64 checksum is not computed by python-modelcif because I'm not sure if we will always see the complete sequence and it would make reading it in a bit more complicated. Unit tests & documentation should work. Has a merge conflict with https://github.com/ihmwg/python-modelcif/pull/14 , that is a number to be increased in test/test_examples.py.

codecov-commenter commented 2 years ago

Codecov Report

Merging #15 (5ca513c) into main (fed5a06) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         1240      1246    +6     
  Branches       331       297   -34     
=========================================
+ Hits          1240      1246    +6
Impacted Files Coverage Δ
modelcif/dumper.py 100.00% <100.00%> (ø)
modelcif/reader.py 100.00% <100.00%> (ø)
modelcif/reference.py 100.00% <100.00%> (ø)
modelcif/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fed5a06...5ca513c. Read the comment docs.

benmwebb commented 2 years ago

Looks good to me... except that it looks like you missed adding seq_db_sequence_checksum. I'll merge this in for now so you get the sequence_version_date support at least.