ihmwg / python-modelcif

Python package for handling ModelCIF mmCIF and BinaryCIF files
MIT License
9 stars 1 forks source link

Multiline string for model details #27

Closed gtauriello closed 2 years ago

gtauriello commented 2 years ago

@benmwebb I noticed that the package can handle multiline strings in general but somehow when I try a multiline string for model_details I get a single line text with escaped '\n' characters.

In the attached zip file here you will find the following:

gtauriello commented 2 years ago

Actually the example was overly complicated and didn't showcase the issue when reading the file back in.

Here a better example: multiline-test.zip

benmwebb commented 2 years ago

Yes, python-ihm only supports output of multiline strings within loop_ constructs, and it doesn't use a loop for _struct. This is an oversight and should be easy to fix.

brindakv commented 2 years ago

@benmwebb multi_line strings should be allowed for model_details but struct should not be looped.

benmwebb commented 2 years ago

The fix does not loop struct.

brindakv commented 2 years ago

Ok thank you. Just wanted to make sure.